Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 56023003: Drop SEC_HAS_CONTENTS condition from section classification for NaCl layout (Closed)

Created:
7 years, 1 month ago by Roland McGrath
Modified:
7 years, 1 month ago
Reviewers:
sehr
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-binutils.git@master
Visibility:
Public.

Description

Drop SEC_HAS_CONTENTS condition from section classification for NaCl layout This check causes it to refuse an RODATA segment that contains nothing but .note.gnu.build-id. The check only ever served to identify a segment of nothing but read-only SHT_NOBITS sections, which never happens in practice and would break things in other ways if it did. BUG= none TEST= manual R=sehr@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-binutils.git;a=commit;h=bf62813

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M bfd/elf-nacl.c View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Roland McGrath
7 years, 1 month ago (2013-11-01 21:34:01 UTC) #1
sehr
lgtm
7 years, 1 month ago (2013-11-01 22:29:04 UTC) #2
Roland McGrath
7 years, 1 month ago (2013-11-01 22:42:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as rbf62813 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698