Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Side by Side Diff: Source/devtools/front_end/NetworkPanel.js

Issue 56023002: [DevTools] Network Panel: get rid of data-urls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/inspector/network-status-non-http-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 727 matching lines...) Expand 10 before | Expand all | Expand 10 after
738 return this._requestsById[id]; 738 return this._requestsById[id];
739 }, 739 },
740 740
741 _onRequestStarted: function(event) 741 _onRequestStarted: function(event)
742 { 742 {
743 this._appendRequest(event.data); 743 this._appendRequest(event.data);
744 }, 744 },
745 745
746 _appendRequest: function(request) 746 _appendRequest: function(request)
747 { 747 {
748 if (request.parsedURL.isDataURL())
pfeldman 2013/11/06 12:53:19 You want to do that on the backend.
749 return;
750
748 this._requests.push(request); 751 this._requests.push(request);
749 752
750 // In case of redirect request id is reassigned to a redirected 753 // In case of redirect request id is reassigned to a redirected
751 // request and we need to update _requestsById and search results. 754 // request and we need to update _requestsById and search results.
752 if (this._requestsById[request.requestId]) { 755 if (this._requestsById[request.requestId]) {
753 var oldRequest = request.redirects[request.redirects.length - 1]; 756 var oldRequest = request.redirects[request.redirects.length - 1];
754 this._requestsById[oldRequest.requestId] = oldRequest; 757 this._requestsById[oldRequest.requestId] = oldRequest;
755 758
756 this._updateSearchMatchedListAfterRequestIdChanged(request.requestId , oldRequest.requestId); 759 this._updateSearchMatchedListAfterRequestIdChanged(request.requestId , oldRequest.requestId);
757 } 760 }
(...skipping 17 matching lines...) Expand all
775 { 778 {
776 var request = /** @type {WebInspector.NetworkRequest} */ (event.data); 779 var request = /** @type {WebInspector.NetworkRequest} */ (event.data);
777 this._refreshRequest(request); 780 this._refreshRequest(request);
778 }, 781 },
779 782
780 /** 783 /**
781 * @param {WebInspector.NetworkRequest} request 784 * @param {WebInspector.NetworkRequest} request
782 */ 785 */
783 _refreshRequest: function(request) 786 _refreshRequest: function(request)
784 { 787 {
788 if (!this._requestsById[request.requestId])
789 return;
785 this._staleRequests[request.requestId] = request; 790 this._staleRequests[request.requestId] = request;
786 this._scheduleRefresh(); 791 this._scheduleRefresh();
787 }, 792 },
788 793
789 clear: function() 794 clear: function()
790 { 795 {
791 if (this._preserveLogToggle.toggled) 796 if (this._preserveLogToggle.toggled)
792 return; 797 return;
793 this._reset(); 798 this._reset();
794 }, 799 },
(...skipping 1696 matching lines...) Expand 10 before | Expand all | Expand 10 after
2491 WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyNa me, revert, a, b) 2496 WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyNa me, revert, a, b)
2492 { 2497 {
2493 var aValue = a._request[propertyName]; 2498 var aValue = a._request[propertyName];
2494 var bValue = b._request[propertyName]; 2499 var bValue = b._request[propertyName];
2495 if (aValue > bValue) 2500 if (aValue > bValue)
2496 return revert ? -1 : 1; 2501 return revert ? -1 : 1;
2497 if (bValue > aValue) 2502 if (bValue > aValue)
2498 return revert ? 1 : -1; 2503 return revert ? 1 : -1;
2499 return 0; 2504 return 0;
2500 } 2505 }
OLDNEW
« no previous file with comments | « LayoutTests/inspector/network-status-non-http-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698