Issue 56023002: [DevTools] Network Panel: get rid of data-urls.

Issue 56023002: [DevTools] Network Panel: get rid of data-urls. (Closed)

Created:
7 years, 1 month ago by eustas

Modified:
7 years, 1 month ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[DevTools] Network Panel: get rid of data-urls. EOM BUG=313845 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161514

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -3 lines)			Patch
M	LayoutTests/inspector/network-status-non-http.html	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	LayoutTests/inspector/network-status-non-http-expected.txt	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/NetworkPanel.js	View	2 chunks	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pfeldman

https://codereview.chromium.org/56023002/diff/1/Source/devtools/front_end/NetworkPanel.js File Source/devtools/front_end/NetworkPanel.js (right): https://codereview.chromium.org/56023002/diff/1/Source/devtools/front_end/NetworkPanel.js#newcode748 Source/devtools/front_end/NetworkPanel.js:748: if (request.parsedURL.isDataURL()) You want to do that on the ...

7 years, 1 month ago (2013-11-06 12:53:19 UTC) #3

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

7 years, 1 month ago (2013-11-06 15:48:51 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/56023002/1

7 years, 1 month ago (2013-11-07 07:08:20 UTC) #6

Message was sent while issue was closed.

Change committed as 161514

Expand Messages | Collapse Messages