Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 560183002: HTML Imports: Let document.defaultView null for imports. (Closed)

Created:
6 years, 3 months ago by Hajime Morrita
Modified:
6 years, 3 months ago
Reviewers:
dglazkov
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

HTML Imports: Let document.defaultView null for imports. This follows the lates spec update: https://www.w3.org/Bugs/Public/show_bug.cgi?id=23170 R=dglazkov@chromium.org BUG=408272 TEST=import-defaultView.html, import-script-prototypes.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M LayoutTests/fast/html/imports/import-defaultView.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/fast/html/imports/import-defaultView-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/html/imports/import-script-prototypes-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/html/imports/resources/script-prototype-test.html View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Hajime Morrita
6 years, 3 months ago (2014-09-10 23:21:43 UTC) #1
dglazkov
lgtm
6 years, 3 months ago (2014-09-11 16:05:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560183002/1
6 years, 3 months ago (2014-09-11 16:06:15 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 16:16:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181826

Powered by Google App Engine
This is Rietveld 408576698