Simplify objects passed to the result stage

expect_tests/type_definitions.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import inspect
 import os
 import re
 
 from collections import namedtuple
 
@@ skipping 133 matching lines @@
     assert f.fully_bound
     return f.func(*f.args, **f.kwargs)
 
   def __repr__(self):
     return 'FuncCall(%r, *%r, **%r)' % (self.func, self.args, self.kwargs)
 
 
 _Test = namedtuple(
     'Test', 'name func_call expect_dir expect_base ext covers breakpoints')
 
+class FakeTest(_Test):
+  """Like Test but without the hard-to-pickle stuff."""
+  pass

[tandrii(chromium), 2014/09/12 17:27:03]

maybe, this:

class TestInfo(namedtuple('TestInfo', 'name expect_dir expect_base ext')):
  def __new__(cls, test):
    """Strips test instance of hard-to-pickle stuff"""
    super(TestInfo, cls).__new__(cls, test.name, test.expect_dir,
test.expect_base, test.ext)

then gen_stage_loop can be simpler:
  ...
  if isinstance(test, Test):
    test = TestInfo(test)
  ...

+
 class Test(_Test):
   TEST_COVERS_MATCH = re.compile('.*/test/([^/]*)_test\.py$')
 
   def __new__(cls, name, func_call, expect_dir=None, expect_base=None,
               ext='json', covers=None, breakpoints=None, break_funcs=()):
     """Create a new test.
 
     @param name: The name of the test. Will be used as the default expect_base
 
     @param func_call: A FuncCall object
@@ skipping 78 matching lines @@
     return self._replace(func_call=self.func_call.bind(*args, **kwargs))
 
   def restrict(self, tests):
     assert tests[0] is self
     return self
 
 
 _MultiTest = namedtuple(
     'MultiTest', 'name make_ctx_call destroy_ctx_call tests atomic')
 
+
+class FakeMultiTest(_MultiTest):

[dnj, 2014/09/12 17:35:38]

Is this used?

+  """Like MultiTest, without the hard-to-pickle stuff."""
+  pass
+
+
 class MultiTest(_MultiTest):
   """A wrapper around one or more Test instances.
 
   Allows the entire group to have common pre- and post- actions and an optional
   shared context between the Test methods (represented by Bind(name='context')).
 
   Args:
     name - The name of the MultiTest. Each Test's name should be prefixed with
         this name, though this is not enforced.
     make_ctx_call - A FuncCall which will be called once before any test in this
@@ skipping 163 matching lines @@
         print 'UNHANDLED:', obj
       return Failure()
 
     def finalize(self, aborted):
       """Called after __call__() has been called for all results.
 
       @param aborted: True if the user aborted the run.
       @type aborted: bool
       """
       pass