Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 56017: Linux: change Skia's fontconfig code to cache SkTypeface objects. (Closed)

Created:
11 years, 9 months ago by agl
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: change Skia's fontconfig code to cache SkTypeface objects. This was a mismatch between my understanding of that the FontHost was supposed to do and the reality. It caused a small memory leak. BUG=8789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M skia/ports/SkFontHost_fontconfig.cpp View 2 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
agl
11 years, 9 months ago (2009-03-27 18:32:51 UTC) #1
Evan Martin
11 years, 9 months ago (2009-03-27 18:36:07 UTC) #2
LGTM with four-space tabs

Powered by Google App Engine
This is Rietveld 408576698