Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 560163002: Fix a bug in Save-Restore no-op optimization. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix a bug in Save-Restore no-op optimization. We optimize Save SaveLayer Restore Restore into NoOp NoOp NoOp Restore I'm considering skipping the call to SkRecordOptimize again just to eliminate this extra variable from landing SkRecord. Thoughts? BUG=skia: Committed: https://skia.googlesource.com/skia/+/99d6a9ee8b3516de892d118c71aa5e6e5c865efd

Patch Set 1 #

Patch Set 2 : comments #

Patch Set 3 : d #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M src/core/SkRecordOpts.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/core/SkRecordPattern.h View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/RecordOptsTest.cpp View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtklein
6 years, 3 months ago (2014-09-10 21:16:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/560163002/40001
6 years, 3 months ago (2014-09-10 21:17:38 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-10 21:17:39 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-10 22:53:32 UTC) #6
robertphillips
lgtm. I think if it is delaying getting SkRecord to stick we should delay it.
6 years, 3 months ago (2014-09-10 23:07:05 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 23:08:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 99d6a9ee8b3516de892d118c71aa5e6e5c865efd

Powered by Google App Engine
This is Rietveld 408576698