components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java - Issue 560153002: Add Cronet Test App that uses libcronet_tests.so with net test utilities.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

Issue 560153002: Add Cronet Test App that uses libcronet_tests.so with net test utilities. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added real waitForActiveShellToBeDoneLoading Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/cronet_loader.cc ('k') | components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/ChunkedWritableByteChannelTest.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/CronetUrlTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

diff --git a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

index 41dda5e13430c567929ac35020a62102965e0245..7d5ee3ca3ada8b3e790983275641db73bb7709df 100644

--- a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

+++ b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

@@ -23,7 +23,6 @@ public class ChromiumUrlRequestFactory extends HttpUrlRequestFactory {

public ChromiumUrlRequestFactory(

Context context, HttpUrlRequestFactoryConfig config) {

if (isEnabled()) {

- System.loadLibrary("cronet");

mRequestContext = new ChromiumUrlRequestContext(

mmenke 2014/09/11 21:10:16 Why does this need to be moved? Doesn't this brea

mef 2014/09/11 22:03:24 Because now cronet_test app loads libcronet_tests.

mmenke 2014/09/11 22:55:13 And what about embedders?

mef 2014/09/12 13:32:47 They should call org.chromium.net.LibraryLoader.en

context.getApplicationContext(), UserAgent.from(context),

config.toString());