Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(22)

Issue 560133004: Let PDFium handle event when there is not yet a visible page. (Closed)

Created:
5 years, 1 month ago by Tom Sepez
Modified:
5 years, 1 month ago
Reviewers:
gene
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Let PDFium handle event when there is not yet a visible page. Speculative fix for 415307. CF will confirm. The stack trace for that bug indicates an attempt to index by -1, which is consistent with no visible page. BUG=415307 Committed: https://crrev.com/9b04ffd8e7a07e9b2947fe5b71acf85dff38a63f Cr-Commit-Position: refs/heads/master@{#295421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M pdf/instance.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tom Sepez
@gene - please review. Thanks.
5 years, 1 month ago (2014-09-17 23:56:50 UTC) #2
gene
lgtm
5 years, 1 month ago (2014-09-18 01:44:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560133004/1
5 years, 1 month ago (2014-09-18 05:04:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as ebfb5b5746da7a3a8d7098b1709ec52ae7df0e11
5 years, 1 month ago (2014-09-18 05:36:06 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2014-09-18 05:37:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b04ffd8e7a07e9b2947fe5b71acf85dff38a63f
Cr-Commit-Position: refs/heads/master@{#295421}

Powered by Google App Engine
This is Rietveld 408576698