Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 560123002: cc:: Add LatencyQuery logic back into OutputSurface. (Closed)

Created:
6 years, 3 months ago by orglofch
Modified:
6 years, 3 months ago
Reviewers:
brianderson
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc:: Add LatencyQuery logic back into OutputSurface. Flickering no longer evident on Note 3 Device. BUG=317928 Committed: https://crrev.com/64579af21919e40dc017eee463a0f5cd53976ad1 Cr-Commit-Position: refs/heads/master@{#294292}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Added comments describing query function. Changed estimation percentile to not use worst case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -3 lines) Patch
M cc/output/output_surface.h View 3 chunks +10 lines, -0 lines 0 comments Download
M cc/output/output_surface.cc View 1 9 chunks +99 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
brianderson
https://codereview.chromium.org/560123002/diff/1/cc/output/output_surface.cc File cc/output/output_surface.cc (right): https://codereview.chromium.org/560123002/diff/1/cc/output/output_surface.cc#newcode38 cc/output/output_surface.cc:38: const double kGpuLatencyEstimationPercentile = 100.0; In other cases where ...
6 years, 3 months ago (2014-09-10 22:36:35 UTC) #3
brianderson
lgtm!
6 years, 3 months ago (2014-09-10 22:56:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560123002/40001
6 years, 3 months ago (2014-09-11 00:17:20 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 40497523d46a5316fa5d704d2ccd615d26702722
6 years, 3 months ago (2014-09-11 01:57:23 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/64579af21919e40dc017eee463a0f5cd53976ad1 Cr-Commit-Position: refs/heads/master@{#294292}
6 years, 3 months ago (2014-09-11 03:09:09 UTC) #10
orglofch
A revert of this CL (patchset #3 id:60001) has been created in https://codereview.chromium.org/564203002/ by orglofch@chromium.org. ...
6 years, 3 months ago (2014-09-12 21:48:05 UTC) #11
orglofch
6 years, 3 months ago (2014-09-18 19:08:24 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/580123003/ by orglofch@chromium.org.

The reason for reverting is: Redundancy in additional query mechanism, will
modify to work using latency_info..

Powered by Google App Engine
This is Rietveld 408576698