runtime/vm/scanner.h - Issue 560113002: Narrow String::CharAt from int32_t to uint16_t.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/scanner.h

Issue 560113002: Narrow String::CharAt from int32_t to uint16_t. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/scanner.h

diff --git a/runtime/vm/scanner.h b/runtime/vm/scanner.h

index 5dde14701a80d53bf96d7e142dddf3c34cd166a9..2c5f64a4f5961606eab4a1a82d297137904e4d29 100644

--- a/runtime/vm/scanner.h

+++ b/runtime/vm/scanner.h

@@ -26,7 +26,7 @@ class String;

// GetStream() scans the entire source text and returns a stream of tokens.

class Scanner : ValueObject {

public:

- typedef int32_t (*CharAtFunc)(const String& str, intptr_t index);

+ typedef uint16_t (*CharAtFunc)(const String& str, intptr_t index);

// SourcePosition describes a text location in user friendly

// terms of line number and column.

« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »