PersonalDataManagerTest should delete temporary directory AFTER WebDataServiceBackend stops using i…

PersonalDataManagerTest should delete temporary directory AFTER WebDataServiceBackend stops using it.

Tests tried to delete temporary directory while it was still in use which
on Windows caused SHFileOperation to block for around 1 second and finally fail.

After this patch test runs at least 15 times faster on Windows.

Committed: https://crrev.com/69e7def044536173f51328ed890eb85695505613
Cr-Commit-Position: refs/heads/master@{#294384}

[mmal, 2014-09-10 19:16:42]

mmaliszkiewicz@opera.com changed reviewers:
+ estade@chromium.org, isherman@chromium.org

[Evan Stade, 2014-09-10 19:20:51]

this patch sounds awesome in theory, but I have to admit I don't fully
understand the code. Ilya, were you the original author?

[Ilya Sherman, 2014-09-10 19:24:11]

LGTM.  Thanks for the fix!

https://codereview.chromium.org/560093002/diff/1/components/autofill/core/bro...
File components/autofill/core/browser/personal_data_manager_unittest.cc (right):

https://codereview.chromium.org/560093002/diff/1/components/autofill/core/bro...
components/autofill/core/browser/personal_data_manager_unittest.cc:101: //
Directory should be deleted at the end to ensure that
nit: "Directory" -> "The temporary directory"

[Ilya Sherman, 2014-09-10 19:25:57]

On 2014/09/10 19:20:51, Evan Stade wrote:
> this patch sounds awesome in theory, but I have to admit I don't fully
> understand the code. Ilya, were you the original author?

I think David originally wrote this, though I was probably the reviewer.

[mmal, 2014-09-11 13:17:55]

The CQ bit was checked by mmaliszkiewicz@opera.com

[commit-bot: I haz the power, 2014-09-11 13:18:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/560093002/20001

[commit-bot: I haz the power, 2014-09-11 14:18:46]

Committed patchset #2 (id:20001) as 21da75f3802dbe718790adfec0816925a1f81a5f

[commit-bot: I haz the power, 2014-09-11 14:22:50]

Patchset 2 (id:??) landed as
https://crrev.com/69e7def044536173f51328ed890eb85695505613
Cr-Commit-Position: refs/heads/master@{#294384}