Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1757)

Unified Diff: ash/system/user/user_view.cc

Issue 560033002: Fixed suggesting adding more users into multi-profile session when we don't have more (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/system/user/user_view.cc
diff --git a/ash/system/user/user_view.cc b/ash/system/user/user_view.cc
index 52f128da1a52fd41b6430984cfed08dbb0682306..1ee3a51bee0a5f3475564cea03c1b1629201f92b 100644
--- a/ash/system/user/user_view.cc
+++ b/ash/system/user/user_view.cc
@@ -499,9 +499,12 @@ void UserView::ToggleAddUserMenuOption() {
bool multi_profile_allowed =
delegate->IsMultiProfileAllowedByPrimaryUserPolicy();
- add_user_disabled_ = (delegate->NumberOfLoggedInUsers() >=
- delegate->GetMaximumNumberOfLoggedInUsers()) ||
- !multi_profile_allowed;
+ int admitted_users_to_be_added =
+ delegate->GetNumberOfAdmittedForMultiProfileUsers();
+ add_user_disabled_ = !multi_profile_allowed ||
+ admitted_users_to_be_added <= 0 ||
dzhioev (left Google) 2014/09/18 07:14:22 Checking for "<= 0" doesn't make sense to me. Can
Roman Sorokin (ftl) 2014/09/22 08:36:06 Done.
+ (delegate->NumberOfLoggedInUsers() >=
+ delegate->GetMaximumNumberOfLoggedInUsers());
ButtonFromView* button = new ButtonFromView(
add_user_view,
@@ -519,6 +522,8 @@ void UserView::ToggleAddUserMenuOption() {
int message_id;
if (!multi_profile_allowed)
message_id = IDS_ASH_STATUS_TRAY_MESSAGE_NOT_ALLOWED_PRIMARY_USER;
+ else if (admitted_users_to_be_added <= 0)
+ message_id = IDS_ASH_STATUS_TRAY_MESSAGE_OUT_OF_USERS;
else
message_id = IDS_ASH_STATUS_TRAY_MESSAGE_CANNOT_ADD_USER;

Powered by Google App Engine
This is Rietveld 408576698