Issue 56003006: cros: Don't load Genius help app in tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 56003006: cros: Don't load Genius help app in tests (Closed)

Created:
7 years, 1 month ago by James Cook

Modified:
7 years, 1 month ago

Reviewers:
Dmitry Polukhin, Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, davidyu

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cros: Don't load Genius help app in tests This breaks some tests in official builds. BUG=None TEST=browser_tests ExtensionProcessManagerBrowserTest R=dpolukhin@chromium.org, yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233008

Patch Set 1 #

Patch Set 2 : rebase #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
	M	chrome/browser/extensions/component_loader.cc	View	1	2 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

James Cook

dpolukhin, yoz PTAL davidyu just FYI I think this was put into the wrong section ...

7 years, 1 month ago (2013-11-01 23:39:34 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/56003006/70001

7 years, 1 month ago (2013-11-05 06:49:42 UTC) #5

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219480

7 years, 1 month ago (2013-11-05 09:46:03 UTC) #6

James Cook

7 years, 1 month ago (2013-11-05 16:59:59 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 manually as r233008 (presubmit successful).

Expand Messages | Collapse Messages