Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 56003002: Revert "Set runtime type on list and map literals." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/backend.dart ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
index de05abe2ba468c18811753b099249a3fc0e27ed5..2519c4fdbabce98ba7fd161277733ff3a47c273c 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
@@ -2024,8 +2024,6 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
push(attachPosition(instruction, node));
}
- HInstruction peek() => stack.last;
-
HInstruction pop() {
return stack.removeLast();
}
@@ -4521,16 +4519,6 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
}
}
- void setRtiIfNeeded(HInstruction object, Node node) {
- InterfaceType type = elements.getType(node);
- if (!backend.classNeedsRti(type.element)) return;
- List<HInstruction> arguments = <HInstruction>[];
- for (DartType argument in type.typeArguments) {
- arguments.add(analyzeTypeArgument(argument));
- }
- callSetRuntimeTypeInfo(type.element, arguments, object);
- }
-
visitLiteralList(LiteralList node) {
HInstruction instruction;
@@ -4546,7 +4534,6 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
}
instruction = buildLiteralList(inputs);
add(instruction);
- setRtiIfNeeded(instruction, node);
}
TypeMask type =
@@ -4749,7 +4736,6 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
add(keyValuePairs);
TypeMask mapType = new TypeMask.nonNullSubtype(backend.mapLiteralClass);
pushInvokeStatic(node, backend.getMapMaker(), [keyValuePairs], mapType);
- setRtiIfNeeded(peek(), node);
}
visitLiteralMapEntry(LiteralMapEntry node) {
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/backend.dart ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698