Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 560003002: Add MutationObserverInit (Closed)

Created:
6 years, 3 months ago by bashi
Modified:
6 years, 3 months ago
Reviewers:
haraken, adamk
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add MutationObserverInit To remove generic Dictionary from MutationObserver. Added Vector<String> -> HashSet<AtomicString> conversion because attributeFilter member in MutationObserverInit is sequence<DOMString>. Tests under fast/dom/MutationObserver cover this change. Spec: http://www.w3.org/TR/dom/#interface-mutationobserver BUG=403150 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181881

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -22 lines) Patch
M Source/core/core.gypi View 1 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/dom/MutationObserver.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/MutationObserver.cpp View 1 3 chunks +15 lines, -20 lines 0 comments Download
M Source/core/dom/MutationObserver.idl View 1 chunk +1 line, -1 line 0 comments Download
A Source/core/dom/MutationObserverInit.idl View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
bashi
Haraken-san, PTAL? Please let me know if I should add more reviewers.
6 years, 3 months ago (2014-09-10 14:27:06 UTC) #2
haraken
LGTM, but let's wait for an approval of adamk.
6 years, 3 months ago (2014-09-10 15:32:33 UTC) #4
haraken
https://codereview.chromium.org/560003002/diff/1/Source/core/dom/MutationObserverInit.idl File Source/core/dom/MutationObserverInit.idl (right): https://codereview.chromium.org/560003002/diff/1/Source/core/dom/MutationObserverInit.idl#newcode4 Source/core/dom/MutationObserverInit.idl:4: Add a link to the spec.
6 years, 3 months ago (2014-09-10 15:33:43 UTC) #5
adamk
lgtm, nice cleanup https://codereview.chromium.org/560003002/diff/1/Source/core/dom/MutationObserverInit.idl File Source/core/dom/MutationObserverInit.idl (right): https://codereview.chromium.org/560003002/diff/1/Source/core/dom/MutationObserverInit.idl#newcode4 Source/core/dom/MutationObserverInit.idl:4: On 2014/09/10 at 15:33:43, haraken wrote: ...
6 years, 3 months ago (2014-09-10 15:50:51 UTC) #6
bashi
Rebased (MutationObserverInit is passed as a reference now) https://codereview.chromium.org/560003002/diff/1/Source/core/dom/MutationObserverInit.idl File Source/core/dom/MutationObserverInit.idl (right): https://codereview.chromium.org/560003002/diff/1/Source/core/dom/MutationObserverInit.idl#newcode4 Source/core/dom/MutationObserverInit.idl:4: On ...
6 years, 3 months ago (2014-09-12 05:27:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560003002/20001
6 years, 3 months ago (2014-09-12 05:28:23 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 06:31:22 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 181881

Powered by Google App Engine
This is Rietveld 408576698