Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 559993005: Move configuration of ResourceConstraints to Isolate construction (Closed)

Created:
6 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

Move configuration of ResourceConstraints to Isolate construction We can only set resource constraints before the isolate is initialized. Since in the future, we want to initialize isolates at construction time, we need to set constraints there. It's possible to later modify the stack limit, so introduce an Isolate::SetStackLimit method for that. The SetResourceConstraints method will be deprecated. Users should pass ResourceConstraints to Isolate::New, and use Isolate::SetStackLimit to later modify the stack limit. BUG=none R=svenpanne@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=23964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -42 lines) Patch
M include/v8.h View 3 chunks +19 lines, -0 lines 0 comments Download
M src/api.cc View 3 chunks +11 lines, -1 line 0 comments Download
M src/d8.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +16 lines, -14 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +27 lines, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-16 08:34:50 UTC) #1
Sven Panne
lgtm
6 years, 3 months ago (2014-09-16 08:42:11 UTC) #2
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-16 09:15:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23964 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698