Source/core/html/TimeRanges.h - Issue 559993004: Fix TimeRanges::nearest() to actually calculate nearest time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/TimeRanges.h

Issue 559993004: Fix TimeRanges::nearest() to actually calculate nearest time. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/TimeRanges.h

diff --git a/Source/core/html/TimeRanges.h b/Source/core/html/TimeRanges.h

index 1a685a7950016b2e12768f0367ad012bb5bf2aa2..3578f42758096ec48d634d7e2cf7bcf223642110 100644

--- a/Source/core/html/TimeRanges.h

+++ b/Source/core/html/TimeRanges.h

@@ -109,7 +109,7 @@ public:

bool contain(double time) const;

- double nearest(double time) const;

+ double nearest(double time, double now) const;

acolwell GONE FROM CHROMIUM 2014/09/11 22:24:39 nit: How about s/time/newPlaybackPosition/ and s/n

DaleCurtis 2014/09/11 22:40:01 I think you must like Java names, but done. :p

void trace(Visitor*);

« no previous file with comments | « Source/core/html/HTMLMediaElement.cpp ('k') | Source/core/html/TimeRanges.cpp » ('j') | Source/core/html/TimeRanges.cpp » ('J')