Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 559973002: Add what-you-typed-match as a result when the input type is URL (Closed)

Created:
6 years, 3 months ago by hashimoto
Modified:
6 years, 3 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add what-you-typed-match as a result when the input type is URL BUG=411426 Committed: https://crrev.com/51b4fe1f52605d55a28ad8018ed1ec8ca908e95d Cr-Commit-Position: refs/heads/master@{#294315}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M athena/main/url_search_provider.cc View 1 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
hashimoto
6 years, 3 months ago (2014-09-10 11:31:27 UTC) #3
Jun Mukai
lgtm with a nit https://codereview.chromium.org/559973002/diff/20001/athena/main/url_search_provider.cc File athena/main/url_search_provider.cc (right): https://codereview.chromium.org/559973002/diff/20001/athena/main/url_search_provider.cc#newcode29 athena/main/url_search_provider.cc:29: const int kScoreForWhatYouTypedResult = 1203; ...
6 years, 3 months ago (2014-09-10 17:13:32 UTC) #4
hashimoto
https://codereview.chromium.org/559973002/diff/20001/athena/main/url_search_provider.cc File athena/main/url_search_provider.cc (right): https://codereview.chromium.org/559973002/diff/20001/athena/main/url_search_provider.cc#newcode29 athena/main/url_search_provider.cc:29: const int kScoreForWhatYouTypedResult = 1203; On 2014/09/10 17:13:32, Jun ...
6 years, 3 months ago (2014-09-11 02:37:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559973002/60001
6 years, 3 months ago (2014-09-11 02:38:10 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:60001) as d89f9b7834cd6876231e41a5df0be8dc1e067b1d
6 years, 3 months ago (2014-09-11 03:42:24 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 04:00:11 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/51b4fe1f52605d55a28ad8018ed1ec8ca908e95d
Cr-Commit-Position: refs/heads/master@{#294315}

Powered by Google App Engine
This is Rietveld 408576698