Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 559933003: [DevTools] Rename DevToolsManagerImpl to DevToolsManager. (Closed)

Created:
6 years, 3 months ago by dgozman
Modified:
6 years, 3 months ago
Reviewers:
yurys, pfeldman
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, vsevik, tzik, horo+watch_chromium.org, jam, serviceworker-reviews, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, nhiroki, devtools-reviews_chromium.org, kinuko+serviceworker, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Rename DevToolsManagerImpl to DevToolsManager. BUG=none TBR=horo@chromium.org Committed: https://crrev.com/73589e8641e95bb6e99b87a6cc0212d37ba684c2 Cr-Commit-Position: refs/heads/master@{#294230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -132 lines) Patch
M content/browser/devtools/devtools_agent_host_impl.cc View 7 chunks +7 lines, -7 lines 0 comments Download
A + content/browser/devtools/devtools_manager.h View 2 chunks +9 lines, -9 lines 0 comments Download
A + content/browser/devtools/devtools_manager.cc View 2 chunks +7 lines, -8 lines 0 comments Download
D content/browser/devtools/devtools_manager_impl.h View 1 chunk +0 lines, -45 lines 0 comments Download
D content/browser/devtools/devtools_manager_impl.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M content/browser/devtools/devtools_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/embedded_worker_devtools_agent_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/devtools/embedded_worker_devtools_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/devtools/forwarding_agent_host.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
dgozman
Could you please take a look?
6 years, 3 months ago (2014-09-10 10:12:05 UTC) #2
pfeldman
lgtm
6 years, 3 months ago (2014-09-10 18:30:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/559933003/1
6 years, 3 months ago (2014-09-10 19:12:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/10057)
6 years, 3 months ago (2014-09-10 19:24:38 UTC) #8
dgozman
TBR'ing horo for service_worker (removing unused include)
6 years, 3 months ago (2014-09-10 19:28:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/559933003/1
6 years, 3 months ago (2014-09-10 19:30:26 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 96d2e3938cd0674209322ff69b9b56866976f781
6 years, 3 months ago (2014-09-10 21:11:47 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 21:25:33 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/73589e8641e95bb6e99b87a6cc0212d37ba684c2
Cr-Commit-Position: refs/heads/master@{#294230}

Powered by Google App Engine
This is Rietveld 408576698