Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 559913002: Rename ascii to one-byte where applicable. (Closed)

Created:
6 years, 3 months ago by Yang
Modified:
6 years, 3 months ago
Reviewers:
dcarney, marja
CC:
v8-dev, dcarney
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+2221 lines, -2548 lines) Patch
M include/v8.h View 13 chunks +37 lines, -29 lines 0 comments Download
M src/accessors.cc View 10 chunks +12 lines, -12 lines 0 comments Download
M src/api.cc View 9 chunks +24 lines, -25 lines 0 comments Download
M src/arm/code-stubs-arm.h View 1 chunk +12 lines, -21 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 16 chunks +36 lines, -47 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 7 chunks +12 lines, -14 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.h View 2 chunks +28 lines, -40 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 9 chunks +49 lines, -73 lines 0 comments Download
M src/arm/regexp-macro-assembler-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 11 chunks +14 lines, -14 lines 0 comments Download
M src/arm64/code-stubs-arm64.h View 1 chunk +11 lines, -12 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 14 chunks +46 lines, -47 lines 0 comments Download
M src/arm64/codegen-arm64.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 2 chunks +24 lines, -42 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 9 chunks +51 lines, -77 lines 0 comments Download
M src/arm64/regexp-macro-assembler-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/regexp-macro-assembler-arm64.cc View 10 chunks +13 lines, -13 lines 0 comments Download
M src/array.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ast-value-factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 15 chunks +34 lines, -37 lines 0 comments Download
M src/contexts.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/conversions.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/counters.h View 1 chunk +122 lines, -124 lines 0 comments Download
M src/d8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M src/extensions/externalize-string-extension.h View 1 chunk +1 line, -1 line 0 comments Download
M src/extensions/externalize-string-extension.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/factory.h View 5 chunks +30 lines, -34 lines 0 comments Download
M src/factory.cc View 9 chunks +29 lines, -25 lines 0 comments Download
M src/global-handles.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/heap.h View 3 chunks +15 lines, -15 lines 0 comments Download
M src/heap/heap.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/heap/heap-inl.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M src/hydrogen.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M src/i18n.cc View 15 chunks +102 lines, -171 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 chunk +13 lines, -18 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 14 chunks +36 lines, -33 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 4 chunks +19 lines, -31 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 11 chunks +37 lines, -43 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 11 chunks +14 lines, -14 lines 0 comments Download
M src/interpreter-irregexp.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M src/json-parser.h View 18 chunks +31 lines, -31 lines 0 comments Download
M src/json-stringifier.h View 20 chunks +33 lines, -33 lines 0 comments Download
M src/jsregexp.h View 15 chunks +30 lines, -29 lines 0 comments Download
M src/jsregexp.cc View 57 chunks +137 lines, -165 lines 3 comments Download
M src/liveedit.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/messages.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 34 chunks +369 lines, -409 lines 0 comments Download
M src/objects.cc View 24 chunks +50 lines, -56 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M src/objects-inl.h View 13 chunks +25 lines, -25 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp-macro-assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp-macro-assembler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/runtime.h View 1 chunk +39 lines, -39 lines 0 comments Download
M src/runtime.cc View 37 chunks +78 lines, -88 lines 0 comments Download
M src/scanner.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/scanner.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/serialize.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/serialize.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/string-search.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/types.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M src/uri.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/uri.js View 2 chunks +3 lines, -3 lines 0 comments Download
M src/utils.h View 3 chunks +2 lines, -17 lines 0 comments Download
M src/vector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.h View 1 chunk +10 lines, -15 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 15 chunks +38 lines, -41 lines 0 comments Download
M src/x64/codegen-x64.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 4 chunks +19 lines, -33 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 9 chunks +42 lines, -53 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 12 chunks +15 lines, -15 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 30 chunks +90 lines, -90 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 9 chunks +35 lines, -35 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-parsing.cc View 8 chunks +16 lines, -16 lines 0 comments Download
M test/cctest/test-regexp.cc View 23 chunks +37 lines, -52 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-strings.cc View 14 chunks +94 lines, -84 lines 0 comments Download
M test/mjsunit/string-external-cached.js View 2 chunks +7 lines, -7 lines 0 comments Download
M test/mjsunit/string-externalize.js View 3 chunks +14 lines, -14 lines 0 comments Download
M test/mjsunit/string-slices.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Yang
https://codereview.chromium.org/559913002/diff/1/src/jsregexp.cc File src/jsregexp.cc (right): https://codereview.chromium.org/559913002/diff/1/src/jsregexp.cc#newcode1602 src/jsregexp.cc:1602: // is it? For example, \u00C5 is equivalent to ...
6 years, 3 months ago (2014-09-10 08:26:36 UTC) #1
dcarney
lgtm https://codereview.chromium.org/559913002/diff/1/src/jsregexp.cc File src/jsregexp.cc (right): https://codereview.chromium.org/559913002/diff/1/src/jsregexp.cc#newcode1602 src/jsregexp.cc:1602: // is it? For example, \u00C5 is equivalent ...
6 years, 3 months ago (2014-09-10 09:35:12 UTC) #3
Yang
6 years, 3 months ago (2014-09-10 12:39:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23840 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698