Issue 559853003: ContentsView pagination model honours kPageTransitionDurationInMs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 559853003: ContentsView pagination model honours kPageTransitionDurationInMs. (Closed)

Created:
6 years, 3 months ago by Matt Giuca

Modified:
6 years, 3 months ago

Reviewers:
calamity

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

ContentsView pagination model honours kPageTransitionDurationInMs. This slows top-level app list page transitions from 120ms to 180ms. BUG=406222 Committed: https://crrev.com/5f74261a86543d56fa550310d92860b8fe91d89a Cr-Commit-Position: refs/heads/master@{#294126}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	ui/app_list/views/contents_view.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/559853003/1

6 years, 3 months ago (2014-09-10 04:39:42 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 07888a3df449104ddf3d3d4d8f3f16622b41b8a9

6 years, 3 months ago (2014-09-10 06:38:09 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 06:44:15 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5f74261a86543d56fa550310d92860b8fe91d89a
Cr-Commit-Position: refs/heads/master@{#294126}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages