Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 559853002: Make gyp_flag_compare.py regenerate and take a target name to make it more usable (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make gyp_flag_compare.py regenerate and take a target name to make it more usable Used to take two text files in obscure ninja format, now expects the targets to compare. e.g. tools/gn/bin/gyp_flag_compare.py base or tools/gn/bin/gyp_flag_compare.py breakpad_processor_support processor_support TBR=brettw@chromium.org BUG=335824 Committed: https://crrev.com/ffcb7f1e0918accebac140f1bdacdfb9c802605c Cr-Commit-Position: refs/heads/master@{#294111}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M tools/gn/bin/gyp_flag_compare.py View 2 chunks +23 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scottmg
6 years, 3 months ago (2014-09-10 03:51:19 UTC) #2
scottmg
(nothing/no one else is using this so I'm just going to check it in)
6 years, 3 months ago (2014-09-10 04:03:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/559853002/1
6 years, 3 months ago (2014-09-10 04:05:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 86fbb0c99c1684180c78c377a5118b6d0511c218
6 years, 3 months ago (2014-09-10 05:26:00 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 05:29:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffcb7f1e0918accebac140f1bdacdfb9c802605c
Cr-Commit-Position: refs/heads/master@{#294111}

Powered by Google App Engine
This is Rietveld 408576698