Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 559843007: metrics: reduce perf periodic collection interval to 3 hours from 24 (Closed)

Created:
6 years, 3 months ago by dhsharp
Modified:
6 years, 3 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org, bjanakiraman1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

metrics: reduce perf periodic collection interval to 3 hours from 24 This should increase the quantity of perf profiles collected for chromiumos-wide-profiling by a factor of 8. Based on the current amount of data received, this should increase the number of profiles collected to a quantity less than it was before the collection scheduling was changed in https://codereview.chromium.org/282093011/ TEST=Not really... This is just turning a knob. I did compile it. BUG=chromium:413951 Committed: https://crrev.com/0f4852aec17e16678d42eb8ac8e1f7544b6740e4 Cr-Commit-Position: refs/heads/master@{#295154}

Patch Set 1 #

Patch Set 2 : Updated description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/metrics/perf_provider_chromeos.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dhsharp
6 years, 3 months ago (2014-09-12 23:57:10 UTC) #2
Ilya Sherman
LGTM
6 years, 3 months ago (2014-09-15 23:33:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559843007/20001
6 years, 3 months ago (2014-09-16 20:51:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6eb3aaaffe8245e5703bdf6afff1981b64cf67d3
6 years, 3 months ago (2014-09-16 21:59:28 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 22:00:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0f4852aec17e16678d42eb8ac8e1f7544b6740e4
Cr-Commit-Position: refs/heads/master@{#295154}

Powered by Google App Engine
This is Rietveld 408576698