Issue 559843006: SheriffOMatic: Add ct-popout-iframe and switch test output iframes to use it.

Issue 559843006: SheriffOMatic: Add ct-popout-iframe and switch test output iframes to use it. (Closed)

Created:
6 years, 3 months ago by Robert Sesek

Modified:
6 years, 3 months ago

Reviewers:
ojan

CC:
ojan, blink-reviews, cbiesinger, dsinclair, jochen (gone - plz use gerrit), leviw_travelin_and_unemployed, michaelpg, szager1, teravest

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

SheriffOMatic: Add ct-popout-iframe and switch test output iframes to use it. BUG=413067 R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181902

Patch Set 2 : Address comments #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -9 lines)			Patch
A	Tools/GardeningServer/ui/ct-popout-iframe.html	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download
M	Tools/GardeningServer/ui/ct-results-panel.html	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	Tools/GardeningServer/ui/ct-test-output.html	View		2 chunks	+4 lines, -7 lines	0 comments	Download
A	Tools/GardeningServer/ui/test/ct-popout-iframe.html	View	1	1 chunk	+41 lines, -0 lines	0 comments	Download
M	Tools/GardeningServer/ui/test/ct-test-output-tests.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ojan

lgtm Yay! https://codereview.chromium.org/559843006/diff/1/Tools/GardeningServer/ui/ct-popout-iframe.html File Tools/GardeningServer/ui/ct-popout-iframe.html (right): https://codereview.chromium.org/559843006/diff/1/Tools/GardeningServer/ui/ct-popout-iframe.html#newcode7 Tools/GardeningServer/ui/ct-popout-iframe.html:7: <polymer-element name="ct-popout-iframe" attributes="src"> Leave out the script ...

6 years, 3 months ago (2014-09-12 00:22:17 UTC) #2

Robert Sesek

https://codereview.chromium.org/559843006/diff/1/Tools/GardeningServer/ui/ct-popout-iframe.html File Tools/GardeningServer/ui/ct-popout-iframe.html (right): https://codereview.chromium.org/559843006/diff/1/Tools/GardeningServer/ui/ct-popout-iframe.html#newcode7 Tools/GardeningServer/ui/ct-popout-iframe.html:7: <polymer-element name="ct-popout-iframe" attributes="src"> On 2014/09/12 00:22:16, ojan-only-code-yellow-reviews wrote: > ...

6 years, 3 months ago (2014-09-12 13:58:59 UTC) #3

Robert Sesek

6 years, 3 months ago (2014-09-12 14:00:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 181902 (presubmit successful).

Expand Messages | Collapse Messages