Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 559843005: MSE: Don't force discontinuity logic on audio frame partial front trimming (Closed)

Created:
6 years, 3 months ago by wolenetz
Modified:
6 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

MSE: Don't force discontinuity logic on audio frame partial front trimming This change removes the signalling of a new media segment when an audio frame is partially front-trimmed. This allows other muxed streams, like video, to not necessarily continue with a keyframe as the next frame processed (unless new media segment has otherwise been signalled). BUG=408216 R=dalecurtis@chromium.org TEST=no media_unittest or mediasource layout test regression Committed: https://crrev.com/bad1c50973b102415b4862636c34d70c0f44335e Cr-Commit-Position: refs/heads/master@{#294885}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M media/filters/frame_processor.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
wolenetz
ptal
6 years, 3 months ago (2014-09-11 23:50:02 UTC) #1
DaleCurtis
lgtm, want to craft a unit test for it?
6 years, 3 months ago (2014-09-12 00:37:54 UTC) #2
wolenetz
On 2014/09/12 00:37:54, DaleCurtis wrote: > lgtm, want to craft a unit test for it? ...
6 years, 3 months ago (2014-09-15 18:35:46 UTC) #3
DaleCurtis
I'd just CQ this then and the test as a separate patch.
6 years, 3 months ago (2014-09-15 18:39:20 UTC) #4
wolenetz
On 2014/09/15 18:39:20, DaleCurtis wrote: > I'd just CQ this then and the test as ...
6 years, 3 months ago (2014-09-15 19:01:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559843005/1
6 years, 3 months ago (2014-09-15 19:16:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 83e19deb65559a199830f7c85b002ad0bb9d37b3
6 years, 3 months ago (2014-09-15 20:36:30 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 20:40:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bad1c50973b102415b4862636c34d70c0f44335e
Cr-Commit-Position: refs/heads/master@{#294885}

Powered by Google App Engine
This is Rietveld 408576698