Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 559843004: Reland inlining updates (Closed)

Created:
6 years, 3 months ago by sigurds
Modified:
6 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland - "Switch inlining to use simplified instead of machine loads." - "Add copy support in inliner." Reland fixes: - size_t conversion for 64bit arches - Don't call front() on empty vector (triggers assertion on windows) - turbo_inlining now implies turbo_types, as it requires simplified lowering. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23911

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase. #

Patch Set 4 : Fix windows bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -53 lines) Patch
M src/compiler/change-lowering-unittest.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/generic-graph.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-graph.h View 1 4 chunks +10 lines, -4 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 2 3 7 chunks +100 lines, -34 lines 0 comments Download
M src/compiler/machine-operator-reducer-unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer-unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/compiler/test-js-constant-cache.cc View 1 2 chunks +9 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sigurds
Trybot indicates the bug has been fixed. Fix is consistent with assertion's message and line ...
6 years, 3 months ago (2014-09-11 14:58:16 UTC) #1
Michael Starzinger
LGTM (rubber-stamped, I assume it is a plain reland).
6 years, 3 months ago (2014-09-11 16:08:19 UTC) #2
sigurds
6 years, 3 months ago (2014-09-12 11:06:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 23911 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698