Make gtest always use simple internal regex engine.

Make gtest always use simple internal regex engine.

In order to allow regex matches in gtest to be shared between Windows and other
systems, we tell gtest to always use it's internal engine.

The syntax supported by the internal engine initially looks like a subset of
POSIX regexs. However character class shortcuts are not valid POSIX.

Even more confusingly the system POSIX regex function often defines extra
features not actually part of the standard allowing regex that work on Linux
fail on Mac OS X.

A search through the code base did not reveal any locations where features not
supported by the internal regex engine where used.

See bug https://code.google.com/p/chromium/issues/detail?id=317224 for more detailed description.

BUG=317224
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241500

[mithro-old, 2013-11-01 17:42:52]

The following targets all depend on the gtest.gyp target and hence need to be
checked.

[u'/fast/chrome/src/breakpad/breakpad.gyp:breakpad_unittests#target',
 u'/fast/chrome/src/build/all.gyp:chromium_swarm_tests#target',
 u'/fast/chrome/src/cc/cc_tests.gyp:cc_perftests#target',
 u'/fast/chrome/src/cc/cc_tests.gyp:cc_unittests#target',
 u'/fast/chrome/src/chrome/chrome.gyp:chrome_app_unittests#target',
 u'/fast/chrome/src/chrome/chrome.gyp:chrome_run#target',
 u'/fast/chrome/src/chrome/chrome.gyp:chromedriver2_tests#target',
 u'/fast/chrome/src/chrome/chrome.gyp:chromedriver2_unittests#target',
 u'/fast/chrome/src/chrome/chrome.gyp:chromedriver_tests#target',
 u'/fast/chrome/src/chrome/chrome.gyp:chromedriver_unittests#target',
 u'/fast/chrome/src/chrome/chrome.gyp:flush_cache#target',
 u'/fast/chrome/src/chrome/chrome.gyp:perf_tests#target',
 u'/fast/chrome/src/chrome/chrome.gyp:performance_browser_tests#target',
 u'/fast/chrome/src/chrome/chrome.gyp:performance_ui_tests#target',
 u'/fast/chrome/src/chrome/chrome.gyp:service_discovery_sniffer#target',
 u'/fast/chrome/src/chrome/chrome.gyp:sync_performance_tests#target',
 u'/fast/chrome/src/chrome/chrome.gyp:test_support_ui_runner#target',
 u'/fast/chrome/src/cloud_print/cloud_print.gyp:cloud_print#target',
 u'/fast/chrome/src/cloud_print/cloud_print.gyp:cloud_print_unittests#target',

u'/fast/chrome/src/components/components_tests.gyp:components_perftests#target',

u'/fast/chrome/src/components/components_tests.gyp:components_unittests#target',

u'/fast/chrome/src/content/content_shell_and_tests.gyp:content_browsertests#target',

u'/fast/chrome/src/content/content_shell_and_tests.gyp:content_gl_benchmark#target',

u'/fast/chrome/src/content/content_shell_and_tests.gyp:content_gl_tests#target',

u'/fast/chrome/src/content/content_shell_and_tests.gyp:content_perftests#target',
 u'/fast/chrome/src/content/content_shell_and_tests.gyp:content_shell#target',

u'/fast/chrome/src/content/content_shell_and_tests.gyp:content_unittests_run#target',

u'/fast/chrome/src/content/content_shell_and_tests.gyp:h264_parser_unittest#target',
 u'/fast/chrome/src/courgette/courgette.gyp:courgette_fuzz#target',
 u'/fast/chrome/src/courgette/courgette.gyp:courgette_unittests#target',
 u'/fast/chrome/src/crypto/crypto.gyp:crypto_unittests#target',
 u'/fast/chrome/src/dbus/dbus.gyp:dbus_test_server#target',
 u'/fast/chrome/src/dbus/dbus.gyp:dbus_unittests#target',
 u'/fast/chrome/src/device/device_tests.gyp:device_unittests#target',
 u'/fast/chrome/src/google_apis/gcm/gcm.gyp:gcm_unit_tests#target',
 u'/fast/chrome/src/google_apis/google_apis.gyp:google_apis_unittests#target',
 u'/fast/chrome/src/gpu/gpu.gyp:gl_tests#target',
 u'/fast/chrome/src/gpu/gpu.gyp:gpu_unittests#target',
 u'/fast/chrome/src/ipc/ipc.gyp:ipc_perftests#target',
 u'/fast/chrome/src/ipc/ipc.gyp:ipc_tests#target',
 u'/fast/chrome/src/jingle/jingle.gyp:jingle_unittests#target',
 u'/fast/chrome/src/media/cast/cast.gyp:cast_unittests#target',
 u'/fast/chrome/src/media/media.gyp:ffmpeg_regression_tests#target',
 u'/fast/chrome/src/media/media.gyp:ffmpeg_unittests#target',
 u'/fast/chrome/src/media/media.gyp:media_perftests#target',
 u'/fast/chrome/src/media/media.gyp:media_unittests#target',
 u'/fast/chrome/src/mojo/mojo.gyp:mojo#target',
 u'/fast/chrome/src/net/net.gyp:crash_cache#target',
 u'/fast/chrome/src/net/net.gyp:dump_cache#target',
 u'/fast/chrome/src/net/net.gyp:fetch_client#target',
 u'/fast/chrome/src/net/net.gyp:net_perftests#target',
 u'/fast/chrome/src/net/net.gyp:run_testserver#target',
 u'/fast/chrome/src/net/net.gyp:stress_cache#target',
 u'/fast/chrome/src/ppapi/ppapi_internal.gyp:ppapi_perftests#target',
 u'/fast/chrome/src/ppapi/ppapi_internal.gyp:ppapi_unittests#target',
 u'/fast/chrome/src/printing/printing.gyp:printing_unittests#target',
 u'/fast/chrome/src/remoting/remoting.gyp:remoting_unittests#target',
 u'/fast/chrome/src/sql/sql.gyp:sql_unittests#target',
 u'/fast/chrome/src/sync/sync.gyp:run_sync_testserver#target',
 u'/fast/chrome/src/sync/sync.gyp:sync_client#target',
 u'/fast/chrome/src/sync/sync.gyp:sync_endtoend_tests#target',
 u'/fast/chrome/src/sync/sync.gyp:sync_listen_notifications#target',
 u'/fast/chrome/src/sync/sync.gyp:sync_unit_tests#target',
 u'/fast/chrome/src/testing/gmock.gyp:gmock_main#target',

u'/fast/chrome/src/third_party/WebKit/Source/platform/blink_platform_tests.gyp:blink_platform_unittests#target',

u'/fast/chrome/src/third_party/WebKit/Source/web/web_tests.gyp:webkit_unit_tests#target',

u'/fast/chrome/src/third_party/WebKit/Source/weborigin/weborigin_tests.gyp:weborigin_unittests#target',

u'/fast/chrome/src/third_party/WebKit/Source/wtf/wtf_tests.gyp:wtf_unittests#target',

u'/fast/chrome/src/third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation_unittests_run#target',

u'/fast/chrome/src/third_party/leveldatabase/leveldatabase.gyp:env_chromium_unittests#target',

u'/fast/chrome/src/third_party/libphonenumber/libphonenumber.gyp:libphonenumber_unittests#target',
 u'/fast/chrome/src/third_party/snappy/snappy.gyp:snappy_unittest#target',
 u'/fast/chrome/src/tools/gn/gn.gyp:gn_unittests#target',

u'/fast/chrome/src/tools/perf/clear_system_cache/clear_system_cache.gyp:clear_system_cache#target',
 u'/fast/chrome/src/ui/compositor/compositor.gyp:compositor_unittests#target',

u'/fast/chrome/src/ui/message_center/message_center.gyp:message_center_unittests#target',
 u'/fast/chrome/src/ui/snapshot/snapshot.gyp:snapshot_unittests#target',
 u'/fast/chrome/src/ui/ui_unittests.gyp:ui_unittests#target',
 u'/fast/chrome/src/url/url.gyp:url_unittests#target',

u'/fast/chrome/src/webkit/renderer/compositor_bindings/compositor_bindings_tests.gyp:webkit_compositor_bindings_unittests#target']

[mithro-old, 2013-11-01 18:29:50]

Hi people,

I've been trying to create more unit tests for blink as part of the animation
rework. After using this stuff for the last couple of weeks, I'd like to make a
change so that gtest/gmock only uses the internal regex engine. This will make
it easier to write tests that are compatible between Mac/Win/Linux. 

The regex engines on Mac/Linux are support different things and you have to use
the internal regex engine on Windows anyway. Looking at it closely the only
common set of functionality are character literals and repeat operators!

I've done as best search as I can to try and figure out if it would adversely
affect anyone. My conclusion so far is that it should be all okay.

I've also build a list all the GYP build targets that depend on the gtest
target. I'm slowly going through the list and making sure there are no new test
failures caused by this change.

Not sure the right way to go about getting this change committed but your name
seems to be blamed for gtest/gmock in chromium. Do you have suggestions?

Tim

[mithro-old, 2013-11-09 11:21:35]

On 2013/11/01 18:29:50, mithro wrote:
> Hi people,
> 
> I've been trying to create more unit tests for blink as part of the animation
> rework. After using this stuff for the last couple of weeks, I'd like to make
a
> change so that gtest/gmock only uses the internal regex engine. This will make
> it easier to write tests that are compatible between Mac/Win/Linux. 
> 
> The regex engines on Mac/Linux are support different things and you have to
use
> the internal regex engine on Windows anyway. Looking at it closely the only
> common set of functionality are character literals and repeat operators!
> 
> I've done as best search as I can to try and figure out if it would adversely
> affect anyone. My conclusion so far is that it should be all okay.
> 
> I've also build a list all the GYP build targets that depend on the gtest
> target. I'm slowly going through the list and making sure there are no new
test
> failures caused by this change.
> 
> Not sure the right way to go about getting this change committed but your name
> seems to be blamed for gtest/gmock in chromium. Do you have suggestions?
> 
> Tim

Poke?

[awong, 2013-11-09 17:14:22]

LGTM

Sorry for the delay.  I do like this change (and your change description).

Before submitting though, can you file a bug and link it from the review
description?  That way if there are questions in the future, there's one central
point to discuss.

-Albert

On 2013/11/09 11:21:35, mithro wrote:
> On 2013/11/01 18:29:50, mithro wrote:
> > Hi people,
> > 
> > I've been trying to create more unit tests for blink as part of the
animation
> > rework. After using this stuff for the last couple of weeks, I'd like to
make
> a
> > change so that gtest/gmock only uses the internal regex engine. This will
make
> > it easier to write tests that are compatible between Mac/Win/Linux. 
> > 
> > The regex engines on Mac/Linux are support different things and you have to
> use
> > the internal regex engine on Windows anyway. Looking at it closely the only
> > common set of functionality are character literals and repeat operators!
> > 
> > I've done as best search as I can to try and figure out if it would
adversely
> > affect anyone. My conclusion so far is that it should be all okay.
> > 
> > I've also build a list all the GYP build targets that depend on the gtest
> > target. I'm slowly going through the list and making sure there are no new
> test
> > failures caused by this change.
> > 
> > Not sure the right way to go about getting this change committed but your
name
> > seems to be blamed for gtest/gmock in chromium. Do you have suggestions?
> > 
> > Tim
> 
> Poke?

[awong, 2013-11-09 17:14:24]

LGTM

Sorry for the delay.  I do like this change (and your change description).

Before submitting though, can you file a bug and link it from the review
description?  That way if there are questions in the future, there's one central
point to discuss.

-Albert

On 2013/11/09 11:21:35, mithro wrote:
> On 2013/11/01 18:29:50, mithro wrote:
> > Hi people,
> > 
> > I've been trying to create more unit tests for blink as part of the
animation
> > rework. After using this stuff for the last couple of weeks, I'd like to
make
> a
> > change so that gtest/gmock only uses the internal regex engine. This will
make
> > it easier to write tests that are compatible between Mac/Win/Linux. 
> > 
> > The regex engines on Mac/Linux are support different things and you have to
> use
> > the internal regex engine on Windows anyway. Looking at it closely the only
> > common set of functionality are character literals and repeat operators!
> > 
> > I've done as best search as I can to try and figure out if it would
adversely
> > affect anyone. My conclusion so far is that it should be all okay.
> > 
> > I've also build a list all the GYP build targets that depend on the gtest
> > target. I'm slowly going through the list and making sure there are no new
> test
> > failures caused by this change.
> > 
> > Not sure the right way to go about getting this change committed but your
name
> > seems to be blamed for gtest/gmock in chromium. Do you have suggestions?
> > 
> > Tim
> 
> Poke?

[mithro-old, 2013-11-10 05:06:58]

On 2013/11/09 17:14:24, awong wrote:
> LGTM
> 
> Sorry for the delay.  I do like this change (and your change description).
> 
> Before submitting though, can you file a bug and link it from the review
> description?  That way if there are questions in the future, there's one
central
> point to discuss.
> 
> -Albert
> 
> On 2013/11/09 11:21:35, mithro wrote:
> > On 2013/11/01 18:29:50, mithro wrote:
> > > Hi people,
> > > 
> > > I've been trying to create more unit tests for blink as part of the
> animation
> > > rework. After using this stuff for the last couple of weeks, I'd like to
> make
> > a
> > > change so that gtest/gmock only uses the internal regex engine. This will
> make
> > > it easier to write tests that are compatible between Mac/Win/Linux. 
> > > 
> > > The regex engines on Mac/Linux are support different things and you have
to
> > use
> > > the internal regex engine on Windows anyway. Looking at it closely the
only
> > > common set of functionality are character literals and repeat operators!
> > > 
> > > I've done as best search as I can to try and figure out if it would
> adversely
> > > affect anyone. My conclusion so far is that it should be all okay.
> > > 
> > > I've also build a list all the GYP build targets that depend on the gtest
> > > target. I'm slowly going through the list and making sure there are no new
> > test
> > > failures caused by this change.
> > > 
> > > Not sure the right way to go about getting this change committed but your
> name
> > > seems to be blamed for gtest/gmock in chromium. Do you have suggestions?
> > > 
> > > Tim
> > 
> > Poke?

Hi Albert,

I've created the bug at
https://code.google.com/p/chromium/issues/detail?id=317224

I feel like this should have some type of announcement or something?

Tim

[commit-bot: I haz the power, 2013-12-04 02:25:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/55983002/190001

[commit-bot: I haz the power, 2013-12-04 03:12:04]

Retried try job too often on android_aosp for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...

[commit-bot: I haz the power, 2013-12-04 04:16:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/55983002/190001

[commit-bot: I haz the power, 2013-12-04 04:51:36]

Retried try job too often on android_aosp for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...

[commit-bot: I haz the power, 2013-12-05 02:17:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/55983002/210001

[commit-bot: I haz the power, 2013-12-05 02:40:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/55983002/210001

[commit-bot: I haz the power, 2013-12-05 03:47:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/55983002/230001

[commit-bot: I haz the power, 2013-12-05 03:59:48]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-12-05 04:44:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/55983002/230001

[commit-bot: I haz the power, 2013-12-05 07:31:51]

Change committed as 238913

[commit-bot: I haz the power, 2013-12-08 23:48:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/55983002/260001

[commit-bot: I haz the power, 2013-12-09 01:38:22]

Change committed as 239423

[sadrul, 2013-12-10 05:45:10]

Hi. This was reverted due to valgrind failure in linux, cros and mac bots.

http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28v...
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28...
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28v...
etc.

[commit-bot: I haz the power, 2013-12-18 02:35:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/55983002/320001

[commit-bot: I haz the power, 2013-12-18 05:31:36]

Change committed as 241500

[mithro-old, 2013-12-19 10:15:45]

Hi Mark,

Can you please take another look.

[mithro-old, 2013-12-19 10:15:45]

Hi Mark,

Can you please take another look.

[mithro-old, 2013-12-19 10:16:15]

On 2013/12/19 10:15:45, mithro wrote:
> Hi Mark,
> 
> Can you please take another look.

Please ignore that message, was wrong CL.