chrome/browser/signin/signin_manager_factory.h - Issue 559823002: Observe chrome::NOTIFICATION_APP_TERMINATING in Chrome's AppListViewDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_manager_factory.h

Issue 559823002: Observe chrome::NOTIFICATION_APP_TERMINATING in Chrome's AppListViewDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/signin/signin_manager_factory.h

diff --git a/chrome/browser/signin/signin_manager_factory.h b/chrome/browser/signin/signin_manager_factory.h

index 03f17f928a3b11314d97a08a27f0738589acfaf3..d18cfe574b9192a63ea251f456dca1e35fb6bfbc 100644

--- a/chrome/browser/signin/signin_manager_factory.h

+++ b/chrome/browser/signin/signin_manager_factory.h

@@ -76,14 +76,8 @@ class SigninManagerFactory : public BrowserContextKeyedServiceFactory {

SigninManagerFactory();

virtual ~SigninManagerFactory();

-#if defined(OS_MACOSX)

- // List of observers. Does not check that list is empty on destruction, as

- // there are some leaky singletons that observe the SigninManagerFactory.

- mutable ObserverList<Observer> observer_list_;

-#else

// List of observers. Checks that list is empty on destruction.

mutable ObserverList<Observer, true> observer_list_;

-#endif

// BrowserContextKeyedServiceFactory:

virtual KeyedService* BuildServiceInstanceFor(

« no previous file with comments | « no previous file | chrome/browser/signin/signin_manager_factory.cc » ('j') | no next file with comments »