Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 559813002: Add HandleScopes to V8DOMActivityLogger's methods (Closed)

Created:
6 years, 3 months ago by haraken
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Add HandleScopes to V8DOMActivityLogger's methods Since these V8DOMActivityLogger's methods can be called from core/ (not via bindings/), it makes sense to allocate a new HandleScope in these methods. BUG=411445 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181694

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/bindings/core/v8/V8DOMActivityLogger.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
haraken
PTAL Another fix for https://code.google.com/p/chromium/issues/detail?id=411445
6 years, 3 months ago (2014-09-10 01:01:00 UTC) #2
yhirano
lgtm
6 years, 3 months ago (2014-09-10 02:24:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/559813002/1
6 years, 3 months ago (2014-09-10 02:25:30 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:26:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181694

Powered by Google App Engine
This is Rietveld 408576698