Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 559793002: cc: Add logging to help pinpoint lost SetNeedsCommit (Closed)

Created:
6 years, 3 months ago by brianderson
Modified:
6 years, 3 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, Sami
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Add logging to help pinpoint lost SetNeedsCommit BUG=393331 NOTRY=true Committed: https://crrev.com/15203f94a12202d25359ea44ffa2666c664b79dc Cr-Commit-Position: refs/heads/master@{#294097}

Patch Set 1 #

Total comments: 2

Patch Set 2 : more logging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M cc/trees/thread_proxy.cc View 1 5 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
brianderson
ptal.
6 years, 3 months ago (2014-09-10 00:12:19 UTC) #2
Ken Russell (switch to Gerrit)
Thank you for putting this in. LGTM with a couple of questions. https://codereview.chromium.org/559793002/diff/1/cc/trees/thread_proxy.cc File cc/trees/thread_proxy.cc ...
6 years, 3 months ago (2014-09-10 00:43:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/559793002/20001
6 years, 3 months ago (2014-09-10 01:09:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/7756)
6 years, 3 months ago (2014-09-10 03:08:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/559793002/20001
6 years, 3 months ago (2014-09-10 03:50:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ef6914691930a667196d5fbbb001ce4003c695ac
6 years, 3 months ago (2014-09-10 03:51:50 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:58:56 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/15203f94a12202d25359ea44ffa2666c664b79dc
Cr-Commit-Position: refs/heads/master@{#294097}

Powered by Google App Engine
This is Rietveld 408576698