Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 559773002: Allow trunk to not end in a slash for git_footers. (Closed)

Created:
6 years, 3 months ago by iannucci
Modified:
6 years, 3 months ago
Reviewers:
prasadv, luqui
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Allow trunk to not end in a slash for git_footers. R=luqui@chromium.org, prasadv@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291897

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M git_footers.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
iannucci
6 years, 3 months ago (2014-09-09 23:02:58 UTC) #1
prasadv
lgtm
6 years, 3 months ago (2014-09-09 23:04:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/559773002/1
6 years, 3 months ago (2014-09-09 23:05:57 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 23:07:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 291897

Powered by Google App Engine
This is Rietveld 408576698