Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 559763002: Make component build Chrome link. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, zea+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/4263a746e6e99a4b6d1388f709bdc7a7572e9c46 Cr-Commit-Position: refs/heads/master@{#294041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M build/config/linux/BUILD.gn View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M google_apis/gcm/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/559763002/1
6 years, 3 months ago (2014-09-09 23:51:57 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-09 23:51:58 UTC) #5
jamesr
lgtm
6 years, 3 months ago (2014-09-09 23:58:31 UTC) #6
brettw
Committed patchset #1 (id:1) to pending queue manually as 49e216d.
6 years, 3 months ago (2014-09-10 00:04:03 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:56:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4263a746e6e99a4b6d1388f709bdc7a7572e9c46
Cr-Commit-Position: refs/heads/master@{#294041}

Powered by Google App Engine
This is Rietveld 408576698