Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 559743002: Cleanup: Use base/files/file_util.h instead of base/file_util.h in cc/, chromecast/, cloud_print/, … (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Use base/files/file_util.h instead of base/file_util.h in cc/, chromecast/, cloud_print/, mojo/, and win8/ TBR=enne@chromium.org,lcwu@chromium.org,vitalybuka@chromium.org,viettrunglluu@chromium.org,cpu@chromium.org Committed: https://crrev.com/90a09082e0f97ca60ffdd887556fcf54005b09a0 Cr-Commit-Position: refs/heads/master@{#294139}

Patch Set 1 #

Patch Set 2 : fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -48 lines) Patch
M cc/test/paths.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/pixel_test.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/pixel_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_common_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/common/cast_paths.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/common/chromecast_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/common/win/install_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/gcp20/prototype/print_job_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/gcp20/prototype/printer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cloud_print/gcp20/prototype/printer_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/chrome_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/cloud_print_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/cloud_print_service_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/service_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/service_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/install/setup.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.h View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor_dll.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M cloud_print/virtual_driver/win/virtual_driver_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/test/js_to_cpp_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/data_pipe_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/test/test_support_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/embedder/platform_channel_pair_posix_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/embedder/simple_platform_shared_buffer_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/dynamic_application_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/out_of_process_dynamic_service_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/shell_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/shell_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/multiprocess_message_pipe_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/platform_handle_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/remote_message_pipe_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/message_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/chrome_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/command_execute_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/test/metro_registration_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/viewer/metro_viewer_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Lei Zhang
(Will TBR OWNERS)
6 years, 3 months ago (2014-09-09 22:01:26 UTC) #2
brettw
rs lgtm
6 years, 3 months ago (2014-09-10 00:09:53 UTC) #3
Lei Zhang
TBR various OWNERS for a mechanical change
6 years, 3 months ago (2014-09-10 06:51:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/559743002/20001
6 years, 3 months ago (2014-09-10 06:58:43 UTC) #7
lcwu1
lgtm on chromecast/.
6 years, 3 months ago (2014-09-10 07:08:45 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c6099ee47075cd48d4c243ee87a939e16aabdd66
6 years, 3 months ago (2014-09-10 08:00:31 UTC) #9
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 3 months ago (2014-09-10 08:32:00 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 10:55:57 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/90a09082e0f97ca60ffdd887556fcf54005b09a0
Cr-Commit-Position: refs/heads/master@{#294139}

Powered by Google App Engine
This is Rietveld 408576698