Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 559723003: Subzero: Add a convenience script for Spec2K. Add the --stats argument. (Closed)

Created:
6 years, 3 months ago by Jim Stichnoth
Modified:
6 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Do an initial scan for unknown components #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -24 lines) Patch
M pydir/szbuild.py View 3 chunks +32 lines, -24 lines 0 comments Download
A pydir/szbuild_spec2k.py View 1 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
6 years, 3 months ago (2014-09-17 05:24:16 UTC) #2
jvoung (off chromium)
lgtm https://codereview.chromium.org/559723003/diff/1/pydir/szbuild_spec2k.py File pydir/szbuild_spec2k.py (right): https://codereview.chromium.org/559723003/diff/1/pydir/szbuild_spec2k.py#newcode29 pydir/szbuild_spec2k.py:29: print 'Ignoring unknown component ' + comp If ...
6 years, 3 months ago (2014-09-17 15:29:09 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/559723003/diff/1/pydir/szbuild_spec2k.py File pydir/szbuild_spec2k.py (right): https://codereview.chromium.org/559723003/diff/1/pydir/szbuild_spec2k.py#newcode29 pydir/szbuild_spec2k.py:29: print 'Ignoring unknown component ' + comp On 2014/09/17 ...
6 years, 3 months ago (2014-09-17 16:18:22 UTC) #4
Jim Stichnoth
6 years, 3 months ago (2014-09-17 16:43:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as cc0ee13 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698