ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc - Issue 559713004: ozone: evdev: Convert CHECKs to DCHECKs per style guide

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc

Issue 559713004: ozone: evdev: Convert CHECKs to DCHECKs per style guide (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/events/ozone/evdev/key_event_converter_evdev_unittest.cc ('k') | ui/events/ozone/evdev/libgestures_glue/gesture_timer_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc

diff --git a/ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc b/ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc

index e49082bd88b8645a6be0099faed2c2056f31b264..b8c990d399f76da5f779870102aa32d3d2096db3 100644

--- a/ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc

+++ b/ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc

@@ -97,14 +97,14 @@ GestureInterpreterLibevdevCros::~GestureInterpreterLibevdevCros() {

void GestureInterpreterLibevdevCros::OnLibEvdevCrosOpen(

Evdev* evdev,

EventStateRec* evstate) {

- CHECK(evdev->info.is_monotonic) << "libevdev must use monotonic timestamps";

+ DCHECK(evdev->info.is_monotonic) << "libevdev must use monotonic timestamps";

VLOG(9) << "HACK DO NOT REMOVE OR LINK WILL FAIL" << (void*)gestures_log;

HardwareProperties hwprops = GestureHardwareProperties(evdev);

GestureInterpreterDeviceClass devclass = GestureDeviceClass(evdev);

// Create & initialize GestureInterpreter.

- CHECK(!interpreter_);

+ DCHECK(!interpreter_);

interpreter_ = NewGestureInterpreter();

GestureInterpreterInitialize(interpreter_, devclass);

GestureInterpreterSetHardwareProperties(interpreter_, &hwprops);