Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issue 559693003: Remove references to WebTouchEvent.changedTouches (Closed)

Created:
6 years, 3 months ago by jdduke (slow)
Modified:
6 years, 3 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, darin-cc_chromium.org, jam, bokan
Base URL:
https://chromium.googlesource.com/chromium/src.git@input_remove_target_changed_touches
Project:
chromium
Visibility:
Public.

Description

Remove references to WebTouchEvent.changedTouches Now that Blink fully populates the |WebTouchEvent.touches| field when offering events to plugins, we can safely stop using |WebTouchEvent.changedTouches|. This is part 3 of a 4-sided patch simplifying WebTouchEvent: 1) https://codereview.chromium.org/557863002/ 2) https://codereview.chromium.org/558773002/ 3) This change 4) https://codereview.chromium.org/560493003/ BUG=358132 Committed: https://crrev.com/dc5b3dc2a1481fa05fbfb4c38a7cff1e6af1454f Cr-Commit-Position: refs/heads/master@{#294390}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove temp event #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -47 lines) Patch
M content/renderer/browser_plugin/browser_plugin.cc View 1 2 chunks +1 line, -47 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jdduke (slow)
fsamuel@: Owner review for content/renderer/browser_plugin/browser_plugin.cc? Sorry for the noise, but this change must be separate ...
6 years, 3 months ago (2014-09-10 00:55:25 UTC) #2
Fady Samuel
https://codereview.chromium.org/559693003/diff/1/content/renderer/browser_plugin/browser_plugin.cc File content/renderer/browser_plugin/browser_plugin.cc (right): https://codereview.chromium.org/559693003/diff/1/content/renderer/browser_plugin/browser_plugin.cc#newcode580 content/renderer/browser_plugin/browser_plugin.cc:580: const blink::WebInputEvent* modified_event = &event; We can probably get ...
6 years, 3 months ago (2014-09-10 01:10:54 UTC) #3
jdduke (slow)
https://codereview.chromium.org/559693003/diff/1/content/renderer/browser_plugin/browser_plugin.cc File content/renderer/browser_plugin/browser_plugin.cc (right): https://codereview.chromium.org/559693003/diff/1/content/renderer/browser_plugin/browser_plugin.cc#newcode580 content/renderer/browser_plugin/browser_plugin.cc:580: const blink::WebInputEvent* modified_event = &event; On 2014/09/10 01:10:54, Fady ...
6 years, 3 months ago (2014-09-10 15:31:23 UTC) #4
Fady Samuel
lgtm! I love it when code gets simpler to read and understand! :D
6 years, 3 months ago (2014-09-10 15:32:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559693003/20001
6 years, 3 months ago (2014-09-11 14:00:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f96fedffdee970d2de5b8cc16da59529a0ec9008
6 years, 3 months ago (2014-09-11 15:14:58 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 15:19:21 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc5b3dc2a1481fa05fbfb4c38a7cff1e6af1454f
Cr-Commit-Position: refs/heads/master@{#294390}

Powered by Google App Engine
This is Rietveld 408576698