Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 559663003: Revert of Revert "net: enable SSL_MODE_CBC_RECORD_SPLITTING with OpenSSL." (Closed)

Created:
6 years, 3 months ago by Ilya Sherman
Modified:
6 years, 3 months ago
Reviewers:
agl, davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "net: enable SSL_MODE_CBC_RECORD_SPLITTING with OpenSSL." (patchset #1 id:1 of https://codereview.chromium.org/547843002/) Reason for revert: Doesn't look like this helped with the perf regression, so undoing the original revert. Original issue's description: > Revert "net: enable SSL_MODE_CBC_RECORD_SPLITTING with OpenSSL." > > This reverts commit e06bd13395c1ed5d93dd35ff3572a79f08bfbab8. > > This is a preemptive revert to see whether a pagecycler regression can > be attributed to this change. (Even if it can, we still probably want to > make the change, but it's good to know.) > > BUG=409214 > TBR=davidben@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/5fee53e7fe9a5a0f6aeb568446d8cdee5e3a96b7 TBR=davidben@chromium.org,agl@chromium.org NOTREECHECKS=true NOTRY=true BUG=409214 Committed: https://crrev.com/e5c05e1e9ccd4dd510ad3d15adafce17bd38e8c2 Cr-Commit-Position: refs/heads/master@{#294001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ilya Sherman
Created Revert of Revert "net: enable SSL_MODE_CBC_RECORD_SPLITTING with OpenSSL."
6 years, 3 months ago (2014-09-09 20:11:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/559663003/1
6 years, 3 months ago (2014-09-09 20:14:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0c4f96ec2e01040beb600de4db33a254d3f90afc
6 years, 3 months ago (2014-09-09 20:34:40 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:55:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5c05e1e9ccd4dd510ad3d15adafce17bd38e8c2
Cr-Commit-Position: refs/heads/master@{#294001}

Powered by Google App Engine
This is Rietveld 408576698