content/browser/frame_host/navigator_impl.cc - Issue 559613002: PlzNavigate: Implement RequestNavigation on the renderer side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 559613002: PlzNavigate: Implement RequestNavigation on the renderer side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@commit-navigation-renderer

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index 340507b76cd538e2bc6b89a847d2d16ce8cc3228..6c3757412ce15cdc780f6faa828acb76e82abb11 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -817,8 +817,8 @@ bool NavigatorImpl::RequestNavigation(

navigation_request_map_.set(frame_tree_node_id, navigation_request.Pass());

if (frame_tree_node->current_frame_host()->IsRenderFrameLive()) {

- // TODO(clamy): send a RequestNavigation IPC.

- NOTIMPLEMENTED();

+ frame_tree_node->current_frame_host()->RequestNavigation(

+ navigation_request->common_params(), request_params);

return true;

}

« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.h » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')