Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 559603004: Separate replacement creation from layer discovery (Closed)

Created:
6 years, 3 months ago by robertphillips
Modified:
6 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Separate replacement creation from layer discovery This is a simple refactoring that sets the stage for eliminating GrReplacements::ReplacementInfo and splitting up EXPERIMENTAL_drawPicture to support multi picture draw. Committed: https://skia.googlesource.com/skia/+/4aa6dfc0b77af9ac298bb9d48991b72a2fec00b2

Patch Set 1 #

Patch Set 2 : Fix rebaselining error #

Total comments: 3

Patch Set 3 : Fixed initializer list order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -32 lines) Patch
M src/gpu/GrLayerCache.h View 1 2 5 chunks +12 lines, -3 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 5 chunks +36 lines, -24 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
robertphillips
6 years, 3 months ago (2014-09-16 21:13:30 UTC) #2
robertphillips
ping
6 years, 3 months ago (2014-09-17 12:32:33 UTC) #3
bsalomon
Sorry for the slow review. https://codereview.chromium.org/559603004/diff/20001/src/gpu/GrLayerCache.h File src/gpu/GrLayerCache.h (right): https://codereview.chromium.org/559603004/diff/20001/src/gpu/GrLayerCache.h#newcode149 src/gpu/GrLayerCache.h:149: const SkPaint* fPaint; Is ...
6 years, 3 months ago (2014-09-17 13:37:37 UTC) #4
robertphillips
https://codereview.chromium.org/559603004/diff/20001/src/gpu/GrLayerCache.h File src/gpu/GrLayerCache.h (right): https://codereview.chromium.org/559603004/diff/20001/src/gpu/GrLayerCache.h#newcode149 src/gpu/GrLayerCache.h:149: const SkPaint* fPaint; I have a TODO to clean ...
6 years, 3 months ago (2014-09-17 13:43:25 UTC) #5
bsalomon
lgtm https://codereview.chromium.org/559603004/diff/20001/src/gpu/GrLayerCache.h File src/gpu/GrLayerCache.h (right): https://codereview.chromium.org/559603004/diff/20001/src/gpu/GrLayerCache.h#newcode149 src/gpu/GrLayerCache.h:149: const SkPaint* fPaint; On 2014/09/17 13:43:24, robertphillips wrote: ...
6 years, 3 months ago (2014-09-17 13:43:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559603004/20001
6 years, 3 months ago (2014-09-17 13:46:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/1673)
6 years, 3 months ago (2014-09-17 13:51:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559603004/40001
6 years, 3 months ago (2014-09-17 14:42:43 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 14:50:52 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 4aa6dfc0b77af9ac298bb9d48991b72a2fec00b2

Powered by Google App Engine
This is Rietveld 408576698