Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Unified Diff: chrome/browser/extensions/extension_management_test_util.h

Issue 559603002: Add new ExtensionManagement preference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes addressing #2 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_management_test_util.h
diff --git a/chrome/browser/extensions/extension_management_test_util.h b/chrome/browser/extensions/extension_management_test_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..6981d4967315e9b256706edc272ff068c6c13a4c
--- /dev/null
+++ b/chrome/browser/extensions/extension_management_test_util.h
@@ -0,0 +1,101 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_MANAGEMENT_TEST_UTIL_H_
+#define CHROME_BROWSER_EXTENSIONS_EXTENSION_MANAGEMENT_TEST_UTIL_H_
+
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/values.h"
+#include "chrome/browser/extensions/extension_management_constants.h"
+#include "extensions/browser/pref_names.h"
Joao da Silva 2014/09/18 15:23:53 Move to .cc
binjin 2014/09/18 15:49:04 It's used in template class in header file.
+#include "extensions/common/extension.h"
+
+namespace extensions {
+
+// Base class for essential routines on preference manipulating.
Joao da Silva 2014/09/18 15:23:53 manipulation
binjin 2014/09/18 15:49:04 Done.
+class ExtensionManagementPrefUpdaterBase {
+ public:
+ ExtensionManagementPrefUpdaterBase();
+ virtual ~ExtensionManagementPrefUpdaterBase();
+
+ // Helper functions for 'installation_mode' manipulating.
Joao da Silva 2014/09/18 15:23:53 manipulation
binjin 2014/09/18 15:49:04 Done.
+ void SetBlacklistedByDefault(bool value);
+ void ClearInstallationModesForIndividualExtensions();
+ void SetIndividualExtensionInstallationAllowed(const ExtensionId& id,
+ bool allowed);
+ void SetIndividualExtensionAutoInstalled(const ExtensionId& id,
+ const std::string& update_url,
Joao da Silva 2014/09/18 15:23:53 #include <string>
binjin 2014/09/18 15:49:03 Done.
+ bool forced);
+
+ // Helper functions for 'install_sources' manipulating.
+ void UnsetInstallSources();
+ void ClearInstallSources();
+ void AddInstallSource(const std::string& install_source);
+ void RemoveInstallSource(const std::string& install_source);
+
+ // Helper functions for 'allowed_types' manipulating.
+ void UnsetAllowedTypes();
+ void ClearAllowedTypes();
+ void AddAllowedType(const std::string& allowed_type);
+ void RemoveAllowedType(const std::string& allowd_type);
+
+ // Expose a read-only preference to user.
+ const base::DictionaryValue* GetPref();
+
+ protected:
+ // Set the preference with |pref|, pass the ownership of it as well.
+ // This function must be called before accessing publicly exposed functions,
+ // for example in constructor of subclass.
+ void SetPref(base::DictionaryValue* pref);
+
+ // Take the preference. Caller takes ownership of it as well.
+ // This function must be called after accessing publicly exposed functions,
+ // for example in destructor of subclass.
+ scoped_ptr<base::DictionaryValue> TakePref();
+
+ private:
+ // Helper functions for manipulating sub properties like list of strings.
+ void ClearList(const std::string& path);
+ void AddStringToList(const std::string& path, const std::string& str);
+ void RemoveStringFromList(const std::string& path, const std::string& str);
+
+ scoped_ptr<base::DictionaryValue> pref_;
+
+ DISALLOW_COPY_AND_ASSIGN(ExtensionManagementPrefUpdaterBase);
+};
+
+// A helper class to manipulate the extension management preference in unit
+// tests.
+template <class TestingPrefService>
+class ExtensionManagementPrefUpdater
+ : public ExtensionManagementPrefUpdaterBase {
+ public:
+ explicit ExtensionManagementPrefUpdater(TestingPrefService* service)
+ : service_(service) {
+ const base::Value* pref_value =
+ service_->GetManagedPref(pref_names::kExtensionManagement);
+ if (pref_value) {
+ const base::DictionaryValue* dict_value = NULL;
+ pref_value->GetAsDictionary(&dict_value);
+ SetPref(dict_value->DeepCopy());
+ } else {
+ SetPref(new base::DictionaryValue);
+ }
+ }
+
+ virtual ~ExtensionManagementPrefUpdater() {
+ service_->SetManagedPref(pref_names::kExtensionManagement,
+ TakePref().release());
+ }
+
+ private:
+ TestingPrefService* service_;
+
+ DISALLOW_COPY_AND_ASSIGN(ExtensionManagementPrefUpdater);
+};
+
+} // namespace extensions
+
+#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_MANAGEMENT_TEST_UTIL_H_

Powered by Google App Engine
This is Rietveld 408576698