Add new ExtensionManagement preference

chrome/browser/extensions/extension_management.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_MANAGEMENT_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_MANAGEMENT_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 13 matching lines @@
 
 class GURL;
 class PrefService;
 
 namespace content {
 class BrowserContext;
 }  // namespace content
 
 namespace extensions {
 
+namespace schema_constants {
+
+extern const char kAllOtherExtension[];
+
+extern const char kInstallationMode[];
+extern const char kAllowed[];
+extern const char kBlocked[];
+extern const char kForceInstalled[];
+extern const char kNormalInstalled[];
+
+extern const char kUpdateUrl[];
+extern const char kInstallSources[];
+extern const char kAllowedTypes[];
+
+extern const char kUpdateUrlPrefix[];
+
+struct AllowedTypesMapType {
+  const char* name;
+  Manifest::Type manifest_type;

[Joao da Silva, 2014/09/18 12:08:22]

Document these 2 fields

[binjin, 2014/09/18 14:37:27]

Done. I also renamed AllowedTypesMapType into AllowedTypesMapEntry.

+};
+
+extern const AllowedTypesMapType kAllowedTypesMap[];

[Joao da Silva, 2014/09/18 12:08:22]

Add a size constant for this array:

extern const size_t kAllowedTypesMapSize;

[binjin, 2014/09/18 14:37:27]

Done.

+
+}  // namespace schema_constants

[Joao da Silva, 2014/09/18 12:08:22]

Move these constants to separate files. This class will be used from many places
and this is just adding noise.

Suggest moving to extension_management_constants.h and .cc

[binjin, 2014/09/18 14:37:27]

Done.

+
 // Tracks the management policies that affect extensions and provides interfaces
 // for observing and obtaining the global settings for all extensions, as well
 // as per-extension settings.
 class ExtensionManagement : public KeyedService {
  public:
   // Observer class for extension management settings changes.
   class Observer {
    public:
     virtual ~Observer() {}
 
@@ skipping 13 matching lines @@
     INSTALLATION_BLOCKED,
     INSTALLATION_FORCED,
     INSTALLATION_RECOMMENDED,
   };
 
   // Class to hold extension management settings for one or a group of
   // extensions. Settings can be applied to an individual extension identified
   // by an ID, a group of extensions with specific |update_url| or all
   // extensions at once.
   struct IndividualSettings {
+    enum Scope {
+      SCOPE_DEFAULT = 0,
+      SCOPE_BY_UPDATE_URL,

[Joao da Silva, 2014/09/18 12:08:22]

This scope is never being used

[binjin, 2014/09/18 14:37:27]

Done.

+      SCOPE_INDIVIDUAL,

[Joao da Silva, 2014/09/18 12:08:22]

Document what each value means

[binjin, 2014/09/18 14:37:27]

Done.

+    };
+
     void Reset();
+    bool Parse(const base::DictionaryValue* dict, Scope scope);

[Joao da Silva, 2014/09/18 12:08:22]

These methods don't belong in the interface either. WDYT of moving them to
anonymous functions in the .cc file? Something like:

namespace {

void Reset(IndividualSettings* settings) {
  ...
}

void Parse(const base::DictionaryValue* dict, Scope scope, IndividualSettings*
settings) {
  Reset(settings);
  ...
}

Then the Scope can also be moved to the .cc. I think it's a good idea to keep
this header file as simple as possible, since it's what external code will use.
Implementation details should be hidden.

[binjin, 2014/09/18 14:37:27]

Done. I left Reset() though.

 
     // Extension installation mode. Setting this to INSTALLATION_FORCED or
     // INSTALLATION_RECOMMENDED will enable extension auto-loading (only
     // applicable to single extension), and in this case the |update_url| must
     // be specified, containing the update URL for this extension.
     // Note that |update_url| will be ignored for INSTALLATION_ALLOWED and
     // INSTALLATION_BLOCKED installation mode.
     InstallationMode installation_mode;
     std::string update_url;
   };
@@ skipping 115 matching lines @@
       content::BrowserContext* context) const OVERRIDE;
   virtual content::BrowserContext* GetBrowserContextToUse(
       content::BrowserContext* context) const OVERRIDE;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionManagementFactory);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_MANAGEMENT_H_