change chrome.wallpaper.setWallpaper api

change chrome.wallpaper.setWallpaper api


change field name from wallpaperData to data
change field name from name to filename

BUG=411286
Committed: https://crrev.com/ca7c6cd6861cac212dddd6448bcb917326cc8bf3
Cr-Commit-Position: refs/heads/master@{#294181}

[ranj, 2014-09-09 15:33:23]

ranj@google.com changed reviewers:
+ bshe@chromium.org

[ranj, 2014-09-09 15:34:47]

The CQ bit was checked by ranj@google.com

[ranj, 2014-09-09 15:34:48]

The CQ bit was unchecked by ranj@google.com

[bshe, 2014-09-09 16:02:28]

bshe@chromium.org changed reviewers:
+ rockot@chromium.org

[bshe, 2014-09-09 16:02:28]

+rockot@

It looks like this link is not working:
https://chrome-apps-doc.appspot.com/_patch/559583002/apps/wallpaper

Is this a server issue or maybe something in the code?

[Ken Rockot(use gerrit already), 2014-09-09 23:24:22]

On 2014/09/09 16:02:28, bshe wrote:
> +rockot@
> 
> It looks like this link is not working:
> https://chrome-apps-doc.appspot.com/_patch/559583002/apps/wallpaper
> 
> Is this a server issue or maybe something in the code?

Yeah the patch feature on the doc server has been pretty flaky, sorry. Change
lgtm though I don't know the status of this API: is it stable? Is this change
going to break things for lots of users?

[bshe, 2014-09-10 11:24:31]

On 2014/09/09 23:24:22, Ken Rockot wrote:
> On 2014/09/09 16:02:28, bshe wrote:
> > +rockot@
> > 
> > It looks like this link is not working:
> > https://chrome-apps-doc.appspot.com/_patch/559583002/apps/wallpaper
> > 
> > Is this a server issue or maybe something in the code?
> 
> Yeah the patch feature on the doc server has been pretty flaky, sorry. Change
> lgtm though I don't know the status of this API: is it stable? Is this change
> going to break things for lots of users?

It is dev channel only. After that change, we want to make it available to
stable channel. It has passed the final API review.

lgtm

[ranj, 2014-09-10 13:58:20]

The CQ bit was checked by ranj@google.com

[commit-bot: I haz the power, 2014-09-10 13:58:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ranj@google.com/559583002/1

[commit-bot: I haz the power, 2014-09-10 15:59:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 15:59:49]

Exceeded time limit waiting for builds to trigger.

[ranj, 2014-09-10 16:55:02]

The CQ bit was checked by ranj@google.com

[commit-bot: I haz the power, 2014-09-10 16:56:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ranj@google.com/559583002/1

[commit-bot: I haz the power, 2014-09-10 16:57:59]

Committed patchset #1 (id:1) as ed7c3f511606eb5a740805ee8f62e5d5e789c65b

[commit-bot: I haz the power, 2014-09-10 17:01:23]

Patchset 1 (id:??) landed as
https://crrev.com/ca7c6cd6861cac212dddd6448bcb917326cc8bf3
Cr-Commit-Position: refs/heads/master@{#294181}

[ranj, 2014-09-22 14:55:39]

Patchset #2 (id:20001) has been deleted