chrome/browser/sessions/session_tab_helper.h - Issue 559523004: Cleanup: Remove unneeded extension_messages.h usage and ifdef out some extensions code usage when e…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/session_tab_helper.h

Issue 559523004: Cleanup: Remove unneeded extension_messages.h usage and ifdef out some extensions code usage when e… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more fixes, rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sessions/session_tab_helper.h

diff --git a/chrome/browser/sessions/session_tab_helper.h b/chrome/browser/sessions/session_tab_helper.h

index d47ec80c956852247d29a35f07f0bc7f0f45bb16..7fb44eb43979ad4fb62b1e8fffb6db0d25ce7ac8 100644

--- a/chrome/browser/sessions/session_tab_helper.h

+++ b/chrome/browser/sessions/session_tab_helper.h

@@ -43,8 +43,10 @@ class SessionTabHelper : public content::WebContentsObserver,

const content::WebContents* tab);

// content::WebContentsObserver:

+#if defined(ENABLE_EXTENSIONS)

Yoyo Zhou 2014/09/18 20:34:02 nit: you could just ifdef out the implementation,

Lei Zhang 2014/09/18 21:31:56 If I ifdef out the impl, but not the method decl h

Yoyo Zhou 2014/09/18 21:41:13 Not the whole impl. The #ifdef could be inside the

virtual void RenderViewCreated(

content::RenderViewHost* render_view_host) OVERRIDE;

+#endif

virtual void UserAgentOverrideSet(const std::string& user_agent) OVERRIDE;

private:

« no previous file with comments | « chrome/browser/extensions/api/messaging/message_service.cc ('k') | chrome/browser/sessions/session_tab_helper.cc » ('j') | no next file with comments »