Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 559523004: Cleanup: Remove unneeded extension_messages.h usage and ifdef out some extensions code usage when e… (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, tfarina, marja+watch_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unneeded extension_messages.h usage and ifdef out some extensions code usage when extensions are disabled. Committed: https://crrev.com/b012bc3d7d404903fb75f3bbee11d95de0ad961b Cr-Commit-Position: refs/heads/master@{#295587}

Patch Set 1 #

Patch Set 2 : fix build #

Patch Set 3 : fix tests #

Patch Set 4 : more fixes, rebase #

Total comments: 3

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -15 lines) Patch
M apps/launcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 16 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/apps/app_url_redirector.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_tab_helper.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_tab_helper.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/themes/theme_syncable_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_internals_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/lazy_background_task_queue.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/api/bluetooth/bluetooth_manifest_permission.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/api/sockets/sockets_manifest_permission.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/api/sockets/sockets_manifest_permission_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/permissions/manifest_permission_set_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/module_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/user_script_set.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Lei Zhang
6 years, 3 months ago (2014-09-17 00:49:59 UTC) #2
Yoyo Zhou
LGTM https://codereview.chromium.org/559523004/diff/60001/chrome/browser/sessions/session_tab_helper.h File chrome/browser/sessions/session_tab_helper.h (right): https://codereview.chromium.org/559523004/diff/60001/chrome/browser/sessions/session_tab_helper.h#newcode46 chrome/browser/sessions/session_tab_helper.h:46: #if defined(ENABLE_EXTENSIONS) nit: you could just ifdef out ...
6 years, 3 months ago (2014-09-18 20:34:03 UTC) #3
Lei Zhang
https://codereview.chromium.org/559523004/diff/60001/chrome/browser/sessions/session_tab_helper.h File chrome/browser/sessions/session_tab_helper.h (right): https://codereview.chromium.org/559523004/diff/60001/chrome/browser/sessions/session_tab_helper.h#newcode46 chrome/browser/sessions/session_tab_helper.h:46: #if defined(ENABLE_EXTENSIONS) On 2014/09/18 20:34:02, Yoyo Zhou wrote: > ...
6 years, 3 months ago (2014-09-18 21:31:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/559523004/80001
6 years, 3 months ago (2014-09-18 21:35:39 UTC) #6
Yoyo Zhou
As I said, it doesn't matter much, but... https://codereview.chromium.org/559523004/diff/60001/chrome/browser/sessions/session_tab_helper.h File chrome/browser/sessions/session_tab_helper.h (right): https://codereview.chromium.org/559523004/diff/60001/chrome/browser/sessions/session_tab_helper.h#newcode46 chrome/browser/sessions/session_tab_helper.h:46: #if ...
6 years, 3 months ago (2014-09-18 21:41:13 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 7fc393742221cfa3ff49a308f24675811c3d3d54
6 years, 3 months ago (2014-09-18 22:57:24 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 22:57:55 UTC) #9
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/b012bc3d7d404903fb75f3bbee11d95de0ad961b
Cr-Commit-Position: refs/heads/master@{#295587}

Powered by Google App Engine
This is Rietveld 408576698