Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 559493002: Temporary revert: Introduce include directive to make_private_script_source.py (Closed)

Created:
6 years, 3 months ago by vivekg_samsung
Modified:
6 years, 3 months ago
Reviewers:
haraken, vivekg, yosin_UTC9
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Temporary revert: Introduce include directive to make_private_script_source.py Reason: As discussed with @haraken over IRC, we need to migrate to using chromium resource, grd, system. In that we may need to think over how to use the include directive. One of the harmony modules, [1], describes about using the 'import "module-name"' directive. We could consider using that as well. As this needs some discussion, we decided to revert this patch first and reconsider landing this once the formal decision is made about it. R=haraken@chromium.org, yosin@chromium.org [1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181640

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M Source/build/scripts/make_private_script_source.py View 3 chunks +5 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
vivekg
PTAL, thanks!
6 years, 3 months ago (2014-09-09 10:45:28 UTC) #2
haraken
LGTM The current <include> rule is preventing us from implementing a GRD system for private ...
6 years, 3 months ago (2014-09-09 10:48:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/559493002/1
6 years, 3 months ago (2014-09-09 11:53:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 181640
6 years, 3 months ago (2014-09-09 12:52:47 UTC) #6
haraken
vivekg@: Do you have any timeline on implementing the GRD system? yosin@ is waiting for ...
6 years, 3 months ago (2014-09-10 02:07:27 UTC) #7
vivekg
On 2014/09/10 02:07:27, haraken wrote: > vivekg@: Do you have any timeline on implementing the ...
6 years, 3 months ago (2014-09-10 02:12:15 UTC) #8
haraken
6 years, 3 months ago (2014-09-10 02:23:23 UTC) #9
Message was sent while issue was closed.
On 2014/09/10 02:12:15, vivekg_ wrote:
> On 2014/09/10 02:07:27, haraken wrote:
> > vivekg@: Do you have any timeline on implementing the GRD system? yosin@ is
> > waiting for the <include> syntax :)
> 
> I am on my way to office and will submit the patch for review in another 1
hours
> time. Is that ok?

That's too quick :)

Powered by Google App Engine
This is Rietveld 408576698