Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: LayoutTests/inspector/documentation/documentation-test.js

Issue 559423004: DevTools: [Documentation] Disable external XHR requests in documentation tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make XHR request always fail in documentation tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | LayoutTests/inspector/documentation/documentation-url-provider.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 function initialize_DocumentationTests()
2 {
3
4 InspectorTest.killLoadXHRWithPrefix = function(urlPrefix)
5 {
6 var originalLoadXHR = window.loadXHR;
7 window.loadXHR = function(url)
8 {
9
lushnikov 2014/09/12 12:44:39 excessive new line
semeny 2014/09/12 12:48:08 Done.
10 if (url.startsWith(urlPrefix))
11 return new Promise(load);
12
13 return originalLoadXHR(url);
14
15 function load(successCallback, failureCallback)
16 {
17 failureCallback();
18 return;
lushnikov 2014/09/12 12:44:39 no need for the return here
semeny 2014/09/12 12:48:08 Done.
19 }
20 }
21 }
22
23 }
OLDNEW
« no previous file with comments | « no previous file | LayoutTests/inspector/documentation/documentation-url-provider.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698