Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 559423004: DevTools: [Documentation] Disable external XHR requests in documentation tests (Closed)

Created:
6 years, 3 months ago by semeny
Modified:
6 years, 3 months ago
Reviewers:
lushnikov, iliia, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: [Documentation] Disable external XHR requests in documentation tests BUG=391593 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181903

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove excessive code #

Total comments: 2

Patch Set 3 : Add urlPrefix to patch #

Patch Set 4 : Make XHR request always fail in documentation tests #

Total comments: 4

Patch Set 5 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
A LayoutTests/inspector/documentation/documentation-test.js View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
M LayoutTests/inspector/documentation/documentation-url-provider.html View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/documentation/DocumentationURLProvider.js View 1 2 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
semeny
6 years, 3 months ago (2014-09-12 10:33:08 UTC) #2
lushnikov
https://codereview.chromium.org/559423004/diff/1/LayoutTests/inspector/documentation/documentation-test.js File LayoutTests/inspector/documentation/documentation-test.js (right): https://codereview.chromium.org/559423004/diff/1/LayoutTests/inspector/documentation/documentation-test.js#newcode8 LayoutTests/inspector/documentation/documentation-test.js:8: return new Promise(load); you want to discretely fall-back to ...
6 years, 3 months ago (2014-09-12 10:47:20 UTC) #3
semeny
6 years, 3 months ago (2014-09-12 10:55:30 UTC) #4
lushnikov
https://codereview.chromium.org/559423004/diff/20001/LayoutTests/inspector/documentation/documentation-url-provider.html File LayoutTests/inspector/documentation/documentation-url-provider.html (right): https://codereview.chromium.org/559423004/diff/20001/LayoutTests/inspector/documentation/documentation-url-provider.html#newcode10 LayoutTests/inspector/documentation/documentation-url-provider.html:10: InspectorTest.mockLoadXHR(WebInspector.DocumentationURLProvider.urlPrefix, ""); what is a urlPrefix?
6 years, 3 months ago (2014-09-12 11:04:49 UTC) #5
semeny
https://codereview.chromium.org/559423004/diff/20001/LayoutTests/inspector/documentation/documentation-url-provider.html File LayoutTests/inspector/documentation/documentation-url-provider.html (right): https://codereview.chromium.org/559423004/diff/20001/LayoutTests/inspector/documentation/documentation-url-provider.html#newcode10 LayoutTests/inspector/documentation/documentation-url-provider.html:10: InspectorTest.mockLoadXHR(WebInspector.DocumentationURLProvider.urlPrefix, ""); On 2014/09/12 11:04:49, lushnikov wrote: > what ...
6 years, 3 months ago (2014-09-12 11:17:38 UTC) #6
lushnikov
Let's rename the issue title into DevTools: [Documentation] Disable external XHR requests in documentation tests ...
6 years, 3 months ago (2014-09-12 12:44:39 UTC) #7
semeny
https://codereview.chromium.org/559423004/diff/60001/LayoutTests/inspector/documentation/documentation-test.js File LayoutTests/inspector/documentation/documentation-test.js (right): https://codereview.chromium.org/559423004/diff/60001/LayoutTests/inspector/documentation/documentation-test.js#newcode9 LayoutTests/inspector/documentation/documentation-test.js:9: On 2014/09/12 12:44:39, lushnikov wrote: > excessive new line ...
6 years, 3 months ago (2014-09-12 12:48:08 UTC) #8
lushnikov
On 2014/09/12 12:48:08, semeny wrote: > https://codereview.chromium.org/559423004/diff/60001/LayoutTests/inspector/documentation/documentation-test.js > File LayoutTests/inspector/documentation/documentation-test.js (right): > > https://codereview.chromium.org/559423004/diff/60001/LayoutTests/inspector/documentation/documentation-test.js#newcode9 > ...
6 years, 3 months ago (2014-09-12 12:58:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559423004/80001
6 years, 3 months ago (2014-09-12 12:58:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/15046)
6 years, 3 months ago (2014-09-12 13:11:57 UTC) #13
loislo
lgtm
6 years, 3 months ago (2014-09-12 13:17:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559423004/80001
6 years, 3 months ago (2014-09-12 13:17:48 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 14:04:51 UTC) #17
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as 181903

Powered by Google App Engine
This is Rietveld 408576698