chrome/browser/resources/options/handler_options_list.js - Issue 559423003: Compile chrome://settings, part 7. 33 errors left

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/handler_options_list.js

Issue 559423003: Compile chrome://settings, part 7. 33 errors left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_5

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/easy_unlock_turn_off_overlay.js ('k') | chrome/browser/resources/options/language_dictionary_overlay.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/handler_options_list.js

diff --git a/chrome/browser/resources/options/handler_options_list.js b/chrome/browser/resources/options/handler_options_list.js

index 3a1334c3ad0ef7505b3d675d6b9e30b0776a3fba..4768b31bbf64f895d11b699b586211102be89e9d 100644

--- a/chrome/browser/resources/options/handler_options_list.js

+++ b/chrome/browser/resources/options/handler_options_list.js

@@ -58,6 +58,10 @@ cr.define('options', function() {

IgnoredHandlersList.prototype = {

__proto__: DeletableItemList.prototype,

+ /**

+ * @override

+ * @param {Object} entry

+ */

createItem: function(entry) {

return new IgnoredHandlersListItem(entry);

@@ -78,7 +82,7 @@ cr.define('options', function() {

* IgnoredHandlersListItem for an example of the format the list should

* take.

- * @param {Object} list A list of ignored protocol handlers.

+ * @param {!Array} list A list of ignored protocol handlers.

setHandlers: function(list) {

this.dataModel = new ArrayDataModel(list);