Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 559413002: [turbofan] Mark operator constructors as const in MachineOperatorBuilder. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Mark operator constructors as const in MachineOperatorBuilder. TEST=compiler-unittests R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23891

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -65 lines) Patch
M src/compiler/machine-operator.h View 2 chunks +60 lines, -60 lines 0 comments Download
M src/compiler/machine-operator.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/compiler/machine-operator-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/machine-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 3 months ago (2014-09-11 10:44:09 UTC) #1
Sven Panne
lgtm
6 years, 3 months ago (2014-09-11 11:28:35 UTC) #2
Benedikt Meurer
6 years, 3 months ago (2014-09-12 04:35:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23891 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698